Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: mojo/public/tools/bindings/mojom.gni

Issue 1875213002: 🏣 Stop including .mojom.js files in GN runtime_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: attach bug Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 mojom_generator_root = "//mojo/public/tools/bindings" 5 mojom_generator_root = "//mojo/public/tools/bindings"
6 mojom_generator_script = "$mojom_generator_root/mojom_bindings_generator.py" 6 mojom_generator_script = "$mojom_generator_root/mojom_bindings_generator.py"
7 mojom_generator_sources = [ 7 mojom_generator_sources = [
8 "$mojom_generator_root/generators/mojom_cpp_generator.py", 8 "$mojom_generator_root/generators/mojom_cpp_generator.py",
9 "$mojom_generator_root/generators/mojom_js_generator.py", 9 "$mojom_generator_root/generators/mojom_js_generator.py",
10 "$mojom_generator_root/generators/mojom_java_generator.py", 10 "$mojom_generator_root/generators/mojom_java_generator.py",
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 } 168 }
169 } 169 }
170 170
171 source_set(target_name) { 171 source_set(target_name) {
172 if (defined(invoker.visibility)) { 172 if (defined(invoker.visibility)) {
173 visibility = invoker.visibility 173 visibility = invoker.visibility
174 } 174 }
175 if (defined(invoker.testonly)) { 175 if (defined(invoker.testonly)) {
176 testonly = invoker.testonly 176 testonly = invoker.testonly
177 } 177 }
178 if (defined(invoker.sources) && !defined(invoker.variant)) { 178
179 # TODO(agrieve): Clients should be setting the data field instead of it
180 # being opportunistically set here. In many cases, the .mojom.js is
181 # put in .pak files, where it should instead be listed as an input to
182 # that action rather than a data. http://crbug.com/603212
183 if (!is_android && defined(invoker.sources) && !defined(invoker.variant)) {
179 data = process_file_template(invoker.sources, generator_js_outputs) 184 data = process_file_template(invoker.sources, generator_js_outputs)
180 } 185 }
181 186
182 public_deps = [ 187 public_deps = [
183 "//mojo/public/cpp/bindings", 188 "//mojo/public/cpp/bindings",
184 ] 189 ]
185 if (defined(invoker.sources)) { 190 if (defined(invoker.sources)) {
186 public_deps += [ ":${cpp_sources_target_name}" ] 191 public_deps += [ ":${cpp_sources_target_name}" ]
187 } 192 }
188 if (defined(invoker.deps)) { 193 if (defined(invoker.deps)) {
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 # //mojo/something:something and we can append "_java" to get the java 303 # //mojo/something:something and we can append "_java" to get the java
299 # dependency name. 304 # dependency name.
300 full_name = get_label_info(d, "label_no_toolchain") 305 full_name = get_label_info(d, "label_no_toolchain")
301 deps += [ "${full_name}_java" ] 306 deps += [ "${full_name}_java" ]
302 } 307 }
303 308
304 srcjar_deps = [ ":$java_srcjar_target_name" ] 309 srcjar_deps = [ ":$java_srcjar_target_name" ]
305 } 310 }
306 } 311 }
307 } 312 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698