Set GVN ChangesNewSpacePromotion for OSR Entry.

Set GVN ChangesNewSpacePromotion for OSR Entry.

BUG=
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15501

[Michael Starzinger, 2013-07-05 07:51:01]

https://codereview.chromium.org/18752002/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/18752002/diff/1/src/hydrogen-instructions.h#n...
src/hydrogen-instructions.h:4721: SetGVNFlag(kChangesNewSpacePromotion);
Shouldn't the HOsrEntry instruction actually have all side-effects?

[titzer, 2013-07-05 08:02:36]

https://codereview.chromium.org/18752002/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/18752002/diff/1/src/hydrogen-instructions.h#n...
src/hydrogen-instructions.h:4721: SetGVNFlag(kChangesNewSpacePromotion);
On 2013/07/05 07:51:01, Michael Starzinger wrote:
> Shouldn't the HOsrEntry instruction actually have all side-effects?

Yes, just SetAllSideEffects().

[Michael Starzinger, 2013-07-05 08:02:42]

LGMT. As discussed offline: I am also fine with just setting this one
side-effect, as HOsrEntry is destined to disappear anyways.

[Michael Starzinger, 2013-07-05 08:08:01]

/s/LGMT/LGTM/ :)

[Hannes Payer (out of office), 2013-07-05 08:17:35]

Committed patchset #1 manually as r15501 (presubmit successful).