Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: src/hydrogen-instructions.h

Issue 18752002: Set GVN ChangesNewSpacePromotion for OSR Entry. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4700 matching lines...) Expand 10 before | Expand all | Expand 10 after
4711 4711
4712 protected: 4712 protected:
4713 virtual bool DataEquals(HValue* other) { return true; } 4713 virtual bool DataEquals(HValue* other) { return true; }
4714 }; 4714 };
4715 4715
4716 4716
4717 class HOsrEntry: public HTemplateInstruction<0> { 4717 class HOsrEntry: public HTemplateInstruction<0> {
4718 public: 4718 public:
4719 explicit HOsrEntry(BailoutId ast_id) : ast_id_(ast_id) { 4719 explicit HOsrEntry(BailoutId ast_id) : ast_id_(ast_id) {
4720 SetGVNFlag(kChangesOsrEntries); 4720 SetGVNFlag(kChangesOsrEntries);
4721 SetGVNFlag(kChangesNewSpacePromotion);
Michael Starzinger 2013/07/05 07:51:01 Shouldn't the HOsrEntry instruction actually have
titzer 2013/07/05 08:02:36 Yes, just SetAllSideEffects().
4721 } 4722 }
4722 4723
4723 BailoutId ast_id() const { return ast_id_; } 4724 BailoutId ast_id() const { return ast_id_; }
4724 4725
4725 virtual Representation RequiredInputRepresentation(int index) { 4726 virtual Representation RequiredInputRepresentation(int index) {
4726 return Representation::None(); 4727 return Representation::None();
4727 } 4728 }
4728 4729
4729 DECLARE_CONCRETE_INSTRUCTION(OsrEntry) 4730 DECLARE_CONCRETE_INSTRUCTION(OsrEntry)
4730 4731
(...skipping 1905 matching lines...) Expand 10 before | Expand all | Expand 10 after
6636 virtual bool IsDeletable() const { return true; } 6637 virtual bool IsDeletable() const { return true; }
6637 }; 6638 };
6638 6639
6639 6640
6640 #undef DECLARE_INSTRUCTION 6641 #undef DECLARE_INSTRUCTION
6641 #undef DECLARE_CONCRETE_INSTRUCTION 6642 #undef DECLARE_CONCRETE_INSTRUCTION
6642 6643
6643 } } // namespace v8::internal 6644 } } // namespace v8::internal
6644 6645
6645 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6646 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698