Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1875033003: Revert of Turn StoreIC::Megamorphic into a builtin, get rid of the non-monomorphic-cache (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Turn StoreIC::Megamorphic into a builtin, get rid of the non-monomorphic-cache (patchset #5 id:80001 of https://codereview.chromium.org/1864703003/ ) Reason for revert: [Sheriff] Check during mksnapshot: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-%20debug%20builder/builds/5950/steps/compile/logs/stdio Original issue's description: > Turn StoreIC::Megamorphic into a builtin, get rid of the non-monomorphic-cache > > BUG= > > Committed: https://crrev.com/8764f87a3399ba433a4ce6f32161181c713af95c > Cr-Commit-Position: refs/heads/master@{#35376} TBR=mvstanton@chromium.org,hpayer@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/2938ef4e45e6aaaf0f4b9359cb4200f8797dfaf7 Cr-Commit-Position: refs/heads/master@{#35379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -35 lines) Patch
M src/builtins.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/heap/heap.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ic/ic.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M src/ic/ic-compiler.h View 3 chunks +39 lines, -5 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 chunk +59 lines, -4 lines 0 comments Download
M src/snapshot/code-serializer.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Turn StoreIC::Megamorphic into a builtin, get rid of the non-monomorphic-cache
4 years, 8 months ago (2016-04-11 11:34:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875033003/1
4 years, 8 months ago (2016-04-11 11:34:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 11:34:46 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 11:36:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2938ef4e45e6aaaf0f4b9359cb4200f8797dfaf7
Cr-Commit-Position: refs/heads/master@{#35379}

Powered by Google App Engine
This is Rietveld 408576698