Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 1864703003: Turn StoreIC::Megamorphic into a builtin, get rid of the non-monomorphic-cache (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn StoreIC::Megamorphic into a builtin, get rid of the non-monomorphic-cache BUG= Committed: https://crrev.com/8764f87a3399ba433a4ce6f32161181c713af95c Cr-Commit-Position: refs/heads/master@{#35376} Committed: https://crrev.com/79ff65075b233d9057b074b4c32977bdeda21d8c Cr-Commit-Position: refs/heads/master@{#35386}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : Fix StoreIC::GenerateMegamorphic #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -139 lines) Patch
M src/builtins.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/builtins.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M src/heap/heap.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 2 chunks +0 lines, -5 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M src/ic/ic.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ic/ic.cc View 1 5 chunks +9 lines, -9 lines 0 comments Download
M src/ic/ic-compiler.h View 1 3 chunks +5 lines, -39 lines 0 comments Download
M src/ic/ic-compiler.cc View 1 1 chunk +4 lines, -59 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/snapshot/code-serializer.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 31 (15 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-06 14:11:01 UTC) #2
mvstanton
lgtm
4 years, 8 months ago (2016-04-07 12:36:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864703003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864703003/40001
4 years, 8 months ago (2016-04-07 12:54:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13356)
4 years, 8 months ago (2016-04-07 12:58:44 UTC) #7
Hannes Payer (out of office)
heap lgtm
4 years, 8 months ago (2016-04-08 06:35:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864703003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864703003/60001
4 years, 8 months ago (2016-04-11 08:52:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/18016)
4 years, 8 months ago (2016-04-11 08:57:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864703003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864703003/80001
4 years, 8 months ago (2016-04-11 09:16:52 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-11 09:36:55 UTC) #18
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/8764f87a3399ba433a4ce6f32161181c713af95c Cr-Commit-Position: refs/heads/master@{#35376}
4 years, 8 months ago (2016-04-11 09:38:21 UTC) #20
Michael Achenbach
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1875033003/ by machenbach@chromium.org. ...
4 years, 8 months ago (2016-04-11 11:34:26 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864703003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864703003/100001
4 years, 8 months ago (2016-04-11 12:07:27 UTC) #25
balazs.kilvady
I am working on the fix for MIPS.
4 years, 8 months ago (2016-04-11 12:13:30 UTC) #26
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-04-11 12:31:35 UTC) #28
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/79ff65075b233d9057b074b4c32977bdeda21d8c Cr-Commit-Position: refs/heads/master@{#35386}
4 years, 8 months ago (2016-04-11 12:31:52 UTC) #30
Toon Verwaest
4 years, 8 months ago (2016-04-11 12:34:49 UTC) #31
Message was sent while issue was closed.
@balazs.kilvady: Oops, I missed your message. Thanks though!

Powered by Google App Engine
This is Rietveld 408576698