Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1875033002: NTP: Fix "Undo" option of the "Item removed" snackbar (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

NTP: Fix "Undo" option of the "Item removed" snackbar Turns out the order-persisting code broke this in some cases. This is a quick fix which just disables that code, for merging to M50. Mid-term, we'll figure out a proper fix or actually remove that code. BUG=585391, 601734 Review URL: https://codereview.chromium.org/1863393007 Cr-Commit-Position: refs/heads/master@{#386040} (cherry picked from commit 8ccdaa9f095e8b911529adcc1c51e47fc2dac102) Committed: https://chromium.googlesource.com/chromium/src/+/8a8aaa9179da4b8287e058b2c95ac8ae6790ad3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/android/most_visited_sites.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Marc Treib
4 years, 8 months ago (2016-04-11 08:21:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a8aaa9179da4b8287e058b2c95ac8ae6790ad3e.

Powered by Google App Engine
This is Rietveld 408576698