Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1863393007: NTP: Fix "Undo" option of the "Item removed" snackbar (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP: Fix "Undo" option of the "Item removed" snackbar Turns out the order-persisting code broke this in some cases. This is a quick fix which just disables that code, for merging to M50. Mid-term, we'll figure out a proper fix or actually remove that code. BUG=585391, 601734 Committed: https://crrev.com/8ccdaa9f095e8b911529adcc1c51e47fc2dac102 Cr-Commit-Position: refs/heads/master@{#386040}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/android/ntp/most_visited_sites.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Marc Treib
Hey, sorry to keep piling them on, but this one is quite urgent... PTAL!
4 years, 8 months ago (2016-04-08 09:33:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863393007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863393007/20001
4 years, 8 months ago (2016-04-08 09:39:33 UTC) #4
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-04-08 10:14:56 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-08 10:19:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863393007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863393007/20001
4 years, 8 months ago (2016-04-08 10:21:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-08 10:26:16 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 10:28:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ccdaa9f095e8b911529adcc1c51e47fc2dac102
Cr-Commit-Position: refs/heads/master@{#386040}

Powered by Google App Engine
This is Rietveld 408576698