Issue 1874973002: Fix font preload crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1874973002: Fix font preload crash (Closed)

Created:
4 years, 8 months ago by Kunihiko Sakamoto

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Fix font preload crash Adds null check for return value of FontResource::fetch(), as well as a test exercising that code path. BUG=600766 Review URL: https://codereview.chromium.org/1867493002 Cr-Commit-Position: refs/heads/master@{#385400} (cherry picked from commit 1470667b97b1ce551060d595f0d41656526ad0f7) Committed: https://chromium.googlesource.com/chromium/src/+/3bfbdd603d53b1e3287ba8b2c731bbf4aee7ece9

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	A	third_party/WebKit/LayoutTests/http/tests/preload/preload-csp.html	View		1 chunk	+17 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/loader/DocumentLoader.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Kunihiko Sakamoto

4 years, 8 months ago (2016-04-11 01:28:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3bfbdd603d53b1e3287ba8b2c731bbf4aee7ece9.