Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1867493002: Fix font preload crash (Closed)

Created:
4 years, 8 months ago by Kunihiko Sakamoto
Modified:
4 years, 8 months ago
Reviewers:
Yoav Weiss, Nate Chapin
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix font preload crash Adds null check for return value of FontResource::fetch(), as well as a test exercising that code path. BUG=600766 Committed: https://crrev.com/1470667b97b1ce551060d595f0d41656526ad0f7 Cr-Commit-Position: refs/heads/master@{#385400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/http/tests/preload/preload-csp.html View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Kunihiko Sakamoto
4 years, 8 months ago (2016-04-06 06:39:15 UTC) #4
Yoav Weiss
On 2016/04/06 06:39:15, Kunihiko Sakamoto wrote: LGTM! Thanks for fixing that.
4 years, 8 months ago (2016-04-06 06:51:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1867493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1867493002/1
4 years, 8 months ago (2016-04-06 06:56:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 08:18:50 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 08:20:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1470667b97b1ce551060d595f0d41656526ad0f7
Cr-Commit-Position: refs/heads/master@{#385400}

Powered by Google App Engine
This is Rietveld 408576698