Issue 18749005: Fixes in sourcemaps discovered in csslib

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18749005: Fixes in sourcemaps discovered in csslib (Closed)

Created:
7 years, 5 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 5 months ago

Reviewers:
dgrove, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixes in sourcemaps discovered in csslib R=dgrove@google.com Committed: https://code.google.com/p/dart/source/detail?r=24881

Patch Set 5 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -35 lines)			Patch
	M	pkg/source_maps/lib/span.dart	View	1 2 3 4	6 chunks	+25 lines, -13 lines	0 comments	Download
	M	pkg/source_maps/test/span_test.dart	View	1 2	2 chunks	+74 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dgrove

lgtm https://codereview.chromium.org/18749005/diff/4001/pkg/source_maps/lib/span.dart File pkg/source_maps/lib/span.dart (right): https://codereview.chromium.org/18749005/diff/4001/pkg/source_maps/lib/span.dart#newcode239 pkg/source_maps/lib/span.dart:239: var res = new String.fromCharCodes(_decodedChars.sublist(max(start, 0), end)); 80 ...

7 years, 5 months ago (2013-07-10 16:53:00 UTC) #2

Siggi Cherem (dart-lang)

thx https://codereview.chromium.org/18749005/diff/4001/pkg/source_maps/lib/span.dart File pkg/source_maps/lib/span.dart (right): https://codereview.chromium.org/18749005/diff/4001/pkg/source_maps/lib/span.dart#newcode239 pkg/source_maps/lib/span.dart:239: var res = new String.fromCharCodes(_decodedChars.sublist(max(start, 0), end)); On ...

7 years, 5 months ago (2013-07-10 16:55:30 UTC) #3

Siggi Cherem (dart-lang)

7 years, 5 months ago (2013-07-10 16:56:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r24881 (presubmit successful).

Expand Messages | Collapse Messages

Issue 18749005: Fixes in sourcemaps discovered in csslib (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Messages