content/browser/devtools/protocol/devtools_protocol_client.h - Issue 1874893002: Convert //content/browser from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/devtools_protocol_client.h

Issue 1874893002: Convert //content/browser from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_browsertest.cc ('k') | content/browser/devtools/protocol/devtools_protocol_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/devtools_protocol_client.h

diff --git a/content/browser/devtools/protocol/devtools_protocol_client.h b/content/browser/devtools/protocol/devtools_protocol_client.h

index ba1a0d79c5379dfc2e9f5e2cfeede8d5e4591624..87003f499e91b36a0559e0c58b7b753f605e3fa7 100644

--- a/content/browser/devtools/protocol/devtools_protocol_client.h

+++ b/content/browser/devtools/protocol/devtools_protocol_client.h

@@ -5,9 +5,10 @@

#ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_DEVTOOLS_PROTOCOL_CLIENT_H_

#define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_DEVTOOLS_PROTOCOL_CLIENT_H_

+#include <memory>

#include "base/callback.h"

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/values.h"

namespace content {

@@ -65,9 +66,9 @@ class DevToolsProtocolClient {

protected:

void SendSuccess(DevToolsCommandId command_id,

- scoped_ptr<base::DictionaryValue> params);

+ std::unique_ptr<base::DictionaryValue> params);

void SendNotification(const std::string& method,

- scoped_ptr<base::DictionaryValue> params);

+ std::unique_ptr<base::DictionaryValue> params);

private:

friend class DevToolsProtocolDispatcher;