content/browser/devtools/protocol/devtools_protocol_client.cc - Issue 1874893002: Convert //content/browser from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/devtools_protocol_client.cc

Issue 1874893002: Convert //content/browser from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_client.h ('k') | content/browser/devtools/protocol/devtools_protocol_handler_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/devtools_protocol_client.cc

diff --git a/content/browser/devtools/protocol/devtools_protocol_client.cc b/content/browser/devtools/protocol/devtools_protocol_client.cc

index 9ca03f9d1ab78ada98a01371675f42e979925748..5f132d92cb7c9571a0cc527ca219f3d165e2af5d 100644

--- a/content/browser/devtools/protocol/devtools_protocol_client.cc

+++ b/content/browser/devtools/protocol/devtools_protocol_client.cc

@@ -53,7 +53,7 @@ void DevToolsProtocolClient::SendMessage(int session_id,

void DevToolsProtocolClient::SendNotification(

const std::string& method,

- scoped_ptr<base::DictionaryValue> params) {

+ std::unique_ptr<base::DictionaryValue> params) {

base::DictionaryValue notification;

notification.SetString(kMethodParam, method);

if (params)

@@ -66,7 +66,7 @@ void DevToolsProtocolClient::SendNotification(

void DevToolsProtocolClient::SendSuccess(

DevToolsCommandId command_id,

- scoped_ptr<base::DictionaryValue> params) {

+ std::unique_ptr<base::DictionaryValue> params) {

base::DictionaryValue response;

response.SetInteger(kIdParam, command_id.call_id);