Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: gpu/config/gpu_util.h

Issue 1874643003: Do not lose secondary gpus and make sure to have an active gpu on multiple gpu configurations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add utility function gpu::ParseSecondaryGpuDevicesFromCommandLine (and rebase) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/config/gpu_util.h
diff --git a/gpu/config/gpu_util.h b/gpu/config/gpu_util.h
index 6b89303d3bbe58acafc8c463be39508d4d4227e5..a2dae66493d1a7e9e629f2e21ba1d21085413079 100644
--- a/gpu/config/gpu_util.h
+++ b/gpu/config/gpu_util.h
@@ -34,6 +34,14 @@ GPU_EXPORT void ApplyGpuDriverBugWorkarounds(
GPU_EXPORT void StringToFeatureSet(
const std::string& str, std::set<int>* feature_set);
+// With provided command line, fill gpu_info->secondary_gpus with parsed
+// secondary vendor and device ids.
+GPU_EXPORT void ParseSecondaryGpuDevicesFromCommandLine(
+ const base::CommandLine& command_line,
+ const std::string& secondary_vendor_ids_key,
Zhenyao Mo 2016/04/19 21:05:27 You really don't need to pass in the two keys here
Julien Isorce Samsung 2016/04/20 17:19:21 Yup but there is the "testing" version of the key.
+ const std::string& secondary_device_ids_key,
+ GPUInfo* gpu_info);
Zhenyao Mo 2016/04/19 21:05:27 Also, can you add a unit test in gpu_util_unittest
Julien Isorce Samsung 2016/04/20 17:19:21 Oki
+
} // namespace gpu
#endif // GPU_CONFIG_GPU_UTIL_H_

Powered by Google App Engine
This is Rietveld 408576698