Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Side by Side Diff: gpu/config/gpu_util.h

Issue 1874643003: Do not lose secondary gpus and make sure to have an active gpu on multiple gpu configurations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add utility function gpu::ParseSecondaryGpuDevicesFromCommandLine (and rebase) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GPU_CONFIG_GPU_UTIL_H_ 5 #ifndef GPU_CONFIG_GPU_UTIL_H_
6 #define GPU_CONFIG_GPU_UTIL_H_ 6 #define GPU_CONFIG_GPU_UTIL_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 16 matching lines...) Expand all
27 // With provided GPUInfo, compute the driver bug workarounds and disabled 27 // With provided GPUInfo, compute the driver bug workarounds and disabled
28 // extensions for the current system, and append the |command_line|. 28 // extensions for the current system, and append the |command_line|.
29 GPU_EXPORT void ApplyGpuDriverBugWorkarounds( 29 GPU_EXPORT void ApplyGpuDriverBugWorkarounds(
30 const GPUInfo& gpu_info, 30 const GPUInfo& gpu_info,
31 base::CommandLine* command_line); 31 base::CommandLine* command_line);
32 32
33 // |str| is in the format of "feature1,feature2,...,featureN". 33 // |str| is in the format of "feature1,feature2,...,featureN".
34 GPU_EXPORT void StringToFeatureSet( 34 GPU_EXPORT void StringToFeatureSet(
35 const std::string& str, std::set<int>* feature_set); 35 const std::string& str, std::set<int>* feature_set);
36 36
37 // With provided command line, fill gpu_info->secondary_gpus with parsed
38 // secondary vendor and device ids.
39 GPU_EXPORT void ParseSecondaryGpuDevicesFromCommandLine(
40 const base::CommandLine& command_line,
41 const std::string& secondary_vendor_ids_key,
Zhenyao Mo 2016/04/19 21:05:27 You really don't need to pass in the two keys here
Julien Isorce Samsung 2016/04/20 17:19:21 Yup but there is the "testing" version of the key.
42 const std::string& secondary_device_ids_key,
43 GPUInfo* gpu_info);
Zhenyao Mo 2016/04/19 21:05:27 Also, can you add a unit test in gpu_util_unittest
Julien Isorce Samsung 2016/04/20 17:19:21 Oki
44
37 } // namespace gpu 45 } // namespace gpu
38 46
39 #endif // GPU_CONFIG_GPU_UTIL_H_ 47 #endif // GPU_CONFIG_GPU_UTIL_H_
40 48
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698