third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h - Issue 1874623002: Implement iterable<DOMString, (StyleValue or sequence<StyleValue>)> for InlineStylePropertyMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h

Issue 1874623002: Implement iterable<DOMString, (StyleValue or sequence<StyleValue>)> for InlineStylePropertyMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@computed-stylepropertymap-2

Patch Set: Address review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iterationWithModification.html ('K') | « third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp ('k') | third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp » ('j') | third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h

diff --git a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h b/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h

index 1eb606082eebef25b6091aa0faff1ebc7b9a4b12..3031dc907f3fcb680307eaefdec35225b668c6f9 100644

--- a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h

+++ b/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h

@@ -21,6 +21,7 @@ class CORE_EXPORT StylePropertyMap : public GarbageCollectedFinalized<StylePrope

DEFINE_WRAPPERTYPEINFO();

public:

typedef HeapVector<Member<StyleValue>> StyleValueVector;

+ typedef std::pair<String, StyleValueOrStyleValueSequence> StylePropertyMapEntry;

virtual ~StylePropertyMap() { }

@@ -48,7 +49,8 @@ public:

protected:

StylePropertyMap() { }

- IterationSource* startIteration(ScriptState*, ExceptionState&) override { return nullptr; }

+ virtual HeapVector<StylePropertyMapEntry> getIterationEntries() = 0;

+ IterationSource* startIteration(ScriptState*, ExceptionState&) override;

StyleValueVector cssValueToStyleValueVector(CSSPropertyID, const CSSValue&);

};