Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp

Issue 1874623002: Implement iterable<DOMString, (StyleValue or sequence<StyleValue>)> for InlineStylePropertyMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@computed-stylepropertymap-2
Patch Set: Address review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp
diff --git a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp b/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp
index cc6cfe380b15f646abce95aa120bc044a784a607..6ae64d92fca32c2dc25d55714b065bfc52f0226a 100644
--- a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp
+++ b/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp
@@ -11,6 +11,40 @@
namespace blink {
+namespace {
+
+class StylePropertyMapIterationSource final : public PairIterable<String, StyleValueOrStyleValueSequence>::IterationSource {
+public:
+ explicit StylePropertyMapIterationSource(HeapVector<StylePropertyMap::StylePropertyMapEntry> values)
+ : m_index(0)
+ , m_values(values)
+ {
+ }
+
+ bool next(ScriptState*, String& key, StyleValueOrStyleValueSequence& value, ExceptionState&) override
+ {
+ if (m_index >= m_values.size())
+ return false;
+
+ StylePropertyMap::StylePropertyMapEntry pair = m_values.at(m_index++);
Timothy Loh 2016/05/13 04:57:45 const Foo&
meade_UTC10 2016/05/13 05:46:34 Done.
+ key = pair.first;
+ value = pair.second;
+ return true;
+ }
+
+ DEFINE_INLINE_VIRTUAL_TRACE()
+ {
+ visitor->trace(m_values);
+ PairIterable<String, StyleValueOrStyleValueSequence>::IterationSource::trace(visitor);
+ }
+
+private:
+ size_t m_index;
+ const HeapVector<StylePropertyMap::StylePropertyMapEntry> m_values;
+};
+
+} // namespace
+
StyleValue* StylePropertyMap::get(const String& propertyName, ExceptionState& exceptionState)
{
CSSPropertyID propertyID = cssPropertyID(propertyName);
@@ -103,4 +137,9 @@ StylePropertyMap::StyleValueVector StylePropertyMap::cssValueToStyleValueVector(
return styleValueVector;
}
+StylePropertyMap::IterationSource* StylePropertyMap::startIteration(ScriptState*, ExceptionState&)
+{
+ return new StylePropertyMapIterationSource(getIterationEntries());
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698