third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h - Issue 1874623002: Implement iterable<DOMString, (StyleValue or sequence<StyleValue>)> for InlineStylePropertyMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

Issue 1874623002: Implement iterable<DOMString, (StyleValue or sequence<StyleValue>)> for InlineStylePropertyMap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@computed-stylepropertymap-2

Patch Set: Address review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iterationWithModification.html ('K') | « third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_iterationWithModification.html ('k') | third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.h » ('j') | third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

diff --git a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

index ba9663d9a3e2923abbdb88b6ad0045ba4be8be3b..68b193f039f082cd99dfe46134b86b96116339e4 100644

--- a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

+++ b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

@@ -37,7 +37,7 @@ protected:

: ImmutableStylePropertyMap()

, m_computedStyleDeclaration(computedStyleDeclaration) { }

- IterationSource* startIteration(ScriptState*, ExceptionState&) override { return nullptr; }

+ HeapVector<StylePropertyMapEntry> getIterationEntries() override { return HeapVector<StylePropertyMapEntry>(); }

Member<CSSStyleDeclaration> m_computedStyleDeclaration;

};