Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1874543002: Inside of content, prefer SiteInstanceImpl to SiteInstance.

Created:
4 years, 8 months ago by ncarter (slow)
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, asanka, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, ajwong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@site_instance_unittest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inside of content, prefer SiteInstanceImpl to SiteInstance. Now that SiteInstanceImpl is a final class, use of the derived type allows devirtualization. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -159 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/mhtml_generation_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/frame_tree.h View 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 10 chunks +15 lines, -15 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigator_impl_unittest.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M content/browser/frame_host/render_frame_host_factory.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 16 chunks +35 lines, -34 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 33 chunks +56 lines, -52 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.h View 3 chunks +4 lines, -6 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/site_instance_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/site_instance_impl.cc View 2 chunks +6 lines, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_frame_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_frame_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_frame_host_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_frame_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1845233003 Patch 80001

Messages

Total messages: 1 (1 generated)
ncarter (slow)
4 years, 8 months ago (2016-04-07 20:59:48 UTC) #1 
Description was changed from

==========
Inside of content, prefer SiteInstanceImpl to SiteInstance.

Now that SiteInstanceImpl is a final class, use of the derived type
allows devirtualization.

BUG=
==========

to

==========
Inside of content, prefer SiteInstanceImpl to SiteInstance.

Now that SiteInstanceImpl is a final class, use of the derived type
allows devirtualization.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

Powered by Google App Engine
This is Rietveld 408576698