content/browser/web_contents/web_contents_impl_unittest.cc - Issue 1874543002: Inside of content, prefer SiteInstanceImpl to SiteInstance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 1874543002: Inside of content, prefer SiteInstanceImpl to SiteInstance. Base URL: https://chromium.googlesource.com/chromium/src.git@site_instance_unittest

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl_unittest.cc

diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc

index 9438c5c16d7c2ef12b01ee72e63a73097969b534..0c8e3a282e2d762ea86f2fe0b4b47efd44d5f552 100644

--- a/content/browser/web_contents/web_contents_impl_unittest.cc

+++ b/content/browser/web_contents/web_contents_impl_unittest.cc

@@ -963,7 +963,7 @@ TEST_F(WebContentsImplTest, FindOpenerRVHWhenPending) {

url2, Referrer(), ui::PAGE_TRANSITION_TYPED, std::string());

orig_rfh->PrepareForCommit();

TestRenderFrameHost* pending_rfh = contents()->GetPendingMainFrame();

- SiteInstance* instance = pending_rfh->GetSiteInstance();

+ SiteInstanceImpl* instance = pending_rfh->GetSiteInstance();

// While it is still pending, simulate opening a new tab with the first tab

// as its opener. This will call CreateOpenerProxies on the opener to ensure

« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/test/test_render_frame_host.h » ('j') | no next file with comments »