Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: chrome/browser/memory_details_win.cc

Issue 1874483002: Remove "from all browsers" memory details mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rip out ProcessInfoSnapshot Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/memory_details_win.cc
diff --git a/chrome/browser/memory_details_win.cc b/chrome/browser/memory_details_win.cc
index e0957bc589b81329ff616929e763bdf745b1980c..7764c39ffff5b496d70c835d563341e289082f11 100644
--- a/chrome/browser/memory_details_win.cc
+++ b/chrome/browser/memory_details_win.cc
@@ -73,7 +73,6 @@ ProcessData* MemoryDetails::ChromeBrowser() {
}
void MemoryDetails::CollectProcessData(
- CollectionMode mode,
const std::vector<ProcessMemoryInformation>& child_info) {
DCHECK(BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
@@ -106,8 +105,7 @@ void MemoryDetails::CollectProcessData(
(windows_architecture == base::win::OSInfo::IA64_ARCHITECTURE)) &&
(base::win::OSInfo::GetWOW64StatusForProcess(process_handle.Get()) ==
base::win::OSInfo::WOW64_DISABLED);
- const size_t browser_list_size =
- (mode == FROM_CHROME_ONLY ? 1 : process_data_.size());
+ const size_t browser_list_size = 1;
for (size_t index2 = 0; index2 < browser_list_size; ++index2) {
Nico 2016/04/08 19:47:44 this loop now always runs exactly once
Elly Fong-Jones 2016/04/13 17:18:24 I'm scared of this code and it has no tests that I
if (_wcsicmp(process_data_[index2].process_name.c_str(),
process_entry.szExeFile) != 0)

Powered by Google App Engine
This is Rietveld 408576698