Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7617)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 187443008: Elim Browser::AppType (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index 8d73b2b1e313c32c08908e676e88a04336fec690..12cfac08113d1ba190d351269c06ec3d2dc48600 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -662,10 +662,9 @@ WebContents* DuplicateTabAt(Browser* browser, int index) {
index + 1, contents_dupe, add_types);
} else {
Browser* new_browser = NULL;
- if (browser->is_app() &&
- !browser->is_type_popup()) {
+ if (browser->is_app() && browser->type() == Browser::TYPE_HOSTED_POPUP) {
new_browser = new Browser(
- Browser::CreateParams::CreateForApp(browser->type(),
+ Browser::CreateParams::CreateForApp(Browser::TYPE_HOSTED_POPUP,
browser->app_name(),
gfx::Rect(),
browser->profile(),
@@ -1241,7 +1240,7 @@ void ConvertTabToAppWindow(Browser* browser,
Browser* app_browser = new Browser(
Browser::CreateParams::CreateForApp(
- Browser::TYPE_POPUP, app_name, gfx::Rect(), browser->profile(),
+ Browser::TYPE_HOSTED_POPUP, app_name, gfx::Rect(), browser->profile(),
browser->host_desktop_type()));
app_browser->tab_strip_model()->AppendWebContents(contents, true);

Powered by Google App Engine
This is Rietveld 408576698