chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java - Issue 1874423002: 🍰 Migrate app shared preferences to ContextUtils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

Issue 1874423002: 🍰 Migrate app shared preferences to ContextUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/provider/ChromeBrowserProvider.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

index e0edbdb8d6f0e819850d29ef3ad0e37da4c3d9a8..9704086c66ea5c3155fa8a8b73ff2ccb8e8ad426 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

@@ -8,9 +8,9 @@ import android.content.Context;

import android.content.SharedPreferences;

import android.net.ConnectivityManager;

import android.net.NetworkInfo;

-import android.preference.PreferenceManager;

import org.chromium.base.CommandLine;

+import org.chromium.base.ContextUtils;

import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ChromeApplication;

@@ -50,7 +50,7 @@ public class PrivacyPreferencesManager implements CrashReportingPermissionManage

@VisibleForTesting

PrivacyPreferencesManager(Context context) {

mContext = context;

- mSharedPreferences = PreferenceManager.getDefaultSharedPreferences(context);

+ mSharedPreferences = ContextUtils.getAppSharedPreferences();

// Crash dump uploading preferences.

// We default the command line flag to disable uploads unless altered on deferred startup

@@ -75,8 +75,7 @@ public class PrivacyPreferencesManager implements CrashReportingPermissionManage

* @return String value of the preference.

public String getPrefCrashDumpUploadPreference() {

- return mSharedPreferences.getString(PREF_CRASH_DUMP_UPLOAD,

- mCrashDumpNeverUpload);

+ return mSharedPreferences.getString(PREF_CRASH_DUMP_UPLOAD, mCrashDumpNeverUpload);

}

/**