Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java

Issue 1874423002: 🍰 Migrate app shared preferences to ContextUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java
index e0d3a4fcc71cf4f981c33063159ac969c075e2c0..adf2f74ee597f7a8f1c0f011709e82df299d496c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/OtherFormsOfHistoryDialogFragment.java
@@ -11,7 +11,6 @@ import android.content.Context;
import android.content.DialogInterface;
import android.content.SharedPreferences;
import android.os.Bundle;
-import android.preference.PreferenceManager;
import android.support.v7.app.AlertDialog;
import android.text.SpannableString;
import android.text.method.LinkMovementMethod;
@@ -19,6 +18,7 @@ import android.view.LayoutInflater;
import android.view.View;
import android.widget.TextView;
+import org.chromium.base.ContextUtils;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
@@ -107,7 +107,7 @@ public class OtherFormsOfHistoryDialogFragment extends DialogFragment implements
*/
private static void recordDialogWasShown(Activity activity, boolean shown) {
SharedPreferences preferences =
- PreferenceManager.getDefaultSharedPreferences(activity);
+ ContextUtils.getAppSharedPreferences();
SharedPreferences.Editor editor = preferences.edit();
editor.putBoolean(PREF_OTHER_FORMS_OF_HISTORY_DIALOG_SHOWN, shown);
editor.apply();
@@ -117,7 +117,7 @@ public class OtherFormsOfHistoryDialogFragment extends DialogFragment implements
* @return Whether the dialog has already been shown to the user before.
*/
static boolean wasDialogShown(Context context) {
- return PreferenceManager.getDefaultSharedPreferences(context).getBoolean(
+ return ContextUtils.getAppSharedPreferences().getBoolean(
PREF_OTHER_FORMS_OF_HISTORY_DIALOG_SHOWN, false);
}

Powered by Google App Engine
This is Rietveld 408576698