Issue 1874001: Migrate web data service logins to the login database correctly on win.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1874001: Migrate web data service logins to the login database correctly on win. (Closed)

Created:
10 years, 7 months ago by albertb

Modified:
9 years, 3 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Migrate web data service logins to the login database correctly on win. BUG=43054 TEST=PasswordStoreWinTest.Migration Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46412

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -13 lines)			Patch
M	chrome/browser/password_manager/password_store_default.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_default.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/password_manager/password_store_win.cc	View	3 4	2 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_win_unittest.cc	View	1	4 chunks	+176 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

albertb

Hi Stuart, This fixes logins not being migrated correctly to the login database under windows. ...

10 years, 7 months ago (2010-05-04 20:33:24 UTC) #1

LGTM