Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2192)

Unified Diff: chrome/browser/password_manager/password_store_default.cc

Issue 1874001: Migrate web data service logins to the login database correctly on win. (Closed)
Patch Set: Fix PSW::OnWeb Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_default.cc
diff --git a/chrome/browser/password_manager/password_store_default.cc b/chrome/browser/password_manager/password_store_default.cc
index 2f5c041cee46125d8ff523d8b414fab57f0a5d2b..31049ddb74b42d29525e703d9e83612a6d3ef14f 100644
--- a/chrome/browser/password_manager/password_store_default.cc
+++ b/chrome/browser/password_manager/password_store_default.cc
@@ -114,10 +114,15 @@ typedef std::vector<const PasswordForm*> PasswordForms;
void PasswordStoreDefault::OnWebDataServiceRequestDone(
WebDataService::Handle handle,
- const WDTypedResult *result) {
+ const WDTypedResult* result) {
DCHECK(handles_.end() != handles_.find(handle));
DCHECK(result);
+ if (PASSWORD_RESULT != result->GetType()) {
+ NOTREACHED();
+ return;
+ }
+
handles_.erase(handle);
if (!result)
return;
« no previous file with comments | « chrome/browser/password_manager/password_store_default.h ('k') | chrome/browser/password_manager/password_store_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698