Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 187393007: Convert some pixel tests in fast/canvas into ref tests. (Closed)

Created:
6 years, 9 months ago by Justin Novosad
Modified:
6 years, 9 months ago
Reviewers:
Stephen White
CC:
blink-reviews
Visibility:
Public.

Description

Convert some pixel tests in fast/canvas into ref tests. This change removes many pixel baselines that were trivial enough to be expressed as reference html. Some of the tests were slightly modified to make them work as ref tests. R=senorblanco@chromium.org BUG=349536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168540

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -270 lines) Patch
M LayoutTests/fast/canvas/canvas-before-css.html View 1 chunk +0 lines, -3 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-before-css-expected.html View 1 chunk +9 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-before-css-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-bg.html View 2 chunks +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-bg-expected.html View 1 chunk +24 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-bg-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-resize-reset.html View 1 chunk +0 lines, -3 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-resize-reset-expected.html View 1 chunk +9 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-resize-reset-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-size-change-after-layout-expected.html View 1 chunk +11 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-size-change-after-layout-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-identity.html View 1 chunk +0 lines, -3 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-transform-identity-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-transform-identity-expected.png View Binary file 0 comments Download
D LayoutTests/fast/canvas/canvas-transform-identity-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-infinity.html View 1 chunk +0 lines, -3 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-transform-infinity-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-transform-infinity-expected.png View Binary file 0 comments Download
D LayoutTests/fast/canvas/canvas-transform-infinity-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-multiply.html View 1 chunk +0 lines, -3 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-transform-multiply-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-transform-multiply-expected.png View Binary file 0 comments Download
D LayoutTests/fast/canvas/canvas-transform-multiply-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-nan.html View 1 chunk +0 lines, -3 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-transform-nan-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-transform-nan-expected.png View Binary file 0 comments Download
D LayoutTests/fast/canvas/canvas-transform-nan-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-non-invertible.html View 1 chunk +0 lines, -3 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-transform-non-invertible-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-transform-non-invertible-expected.png View Binary file 0 comments Download
D LayoutTests/fast/canvas/canvas-transform-non-invertible-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-transform-skewed.html View 1 chunk +4 lines, -5 lines 2 comments Download
A LayoutTests/fast/canvas/canvas-transform-skewed-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-transform-skewed-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A LayoutTests/fast/canvas/canvas-zoom-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-zoom-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
M LayoutTests/fast/canvas/canvasDrawingIntoSelf.html View 1 chunk +3 lines, -5 lines 0 comments Download
A LayoutTests/fast/canvas/canvasDrawingIntoSelf-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/canvasDrawingIntoSelf-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A LayoutTests/fast/canvas/check-stale-putImageData-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/check-stale-putImageData-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/canvas/drawImage.html View 2 chunks +3 lines, -5 lines 0 comments Download
A LayoutTests/fast/canvas/drawImage-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/drawImage-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/fill-stroke-clip-reset-path.html View 2 chunks +10 lines, -24 lines 0 comments Download
A LayoutTests/fast/canvas/fill-stroke-clip-reset-path-expected.html View 1 chunk +25 lines, -0 lines 0 comments Download
D LayoutTests/fast/canvas/fill-stroke-clip-reset-path-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/canvas/fillrect-gradient-zero-stops.html View 1 chunk +0 lines, -5 lines 0 comments Download
A + LayoutTests/fast/canvas/fillrect-gradient-zero-stops-expected.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/canvas/fillrect-gradient-zero-stops-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/font-update.html View 1 chunk +0 lines, -1 line 1 comment Download
A + LayoutTests/fast/canvas/font-update-expected.html View 1 chunk +1 line, -12 lines 0 comments Download
D LayoutTests/fast/canvas/font-update-expected.png View Binary file 0 comments Download
D LayoutTests/fast/canvas/font-update-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/patternfill-repeat.html View 2 chunks +0 lines, -5 lines 0 comments Download
A + LayoutTests/fast/canvas/patternfill-repeat-expected.html View 2 chunks +41 lines, -21 lines 0 comments Download
D LayoutTests/fast/canvas/patternfill-repeat-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/canvas/zero-size-fill-rect.html View 1 chunk +2 lines, -3 lines 1 comment Download
D LayoutTests/platform/linux/fast/canvas/canvas-before-css-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/canvas-bg-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/canvas-resize-reset-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/canvas-size-change-after-layout-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/canvas-zoom-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/canvasDrawingIntoSelf-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/check-stale-putImageData-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/drawImage-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/fill-stroke-clip-reset-path-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/fillrect-gradient-zero-stops-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/patternfill-repeat-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/zero-size-fill-rect-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-before-css-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-bg-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-bg-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-resize-reset-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvasDrawingIntoSelf-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/drawImage-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/fill-stroke-clip-reset-path-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/patternfill-repeat-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/zero-size-fill-rect-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/canvas/canvas-bg-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/canvas/canvas-bg-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/mac-lion/virtual/gpu/fast/canvas/canvas-bg-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/virtual/gpu/fast/canvas/canvas-bg-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/mac-mountainlion/fast/canvas/canvas-bg-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/virtual/gpu/fast/canvas/canvas-bg-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/canvas/canvas-bg-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/canvas/canvas-bg-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/mac-snowleopard/virtual/gpu/fast/canvas/canvas-bg-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/virtual/gpu/fast/canvas/canvas-bg-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/mac/fast/canvas/canvas-before-css-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/canvas-bg-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/canvas-resize-reset-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/canvas-size-change-after-layout-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/canvas-transform-skewed-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/canvas-zoom-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/canvasDrawingIntoSelf-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/check-stale-putImageData-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/drawImage-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/fill-stroke-clip-reset-path-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/fillrect-gradient-zero-stops-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/font-update-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/patternfill-repeat-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/zero-size-fill-rect-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-before-css-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-bg-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-resize-reset-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-size-change-after-layout-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-zoom-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvasDrawingIntoSelf-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/check-stale-putImageData-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/drawImage-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/fill-stroke-clip-reset-path-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/font-update-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/patternfill-repeat-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/zero-size-fill-rect-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/canvas-before-css-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/canvas-bg-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/canvas-resize-reset-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/canvas-size-change-after-layout-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/canvas-size-change-after-layout-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/win/fast/canvas/canvas-transform-skewed-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/canvas-zoom-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/canvas-zoom-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/platform/win/fast/canvas/canvasDrawingIntoSelf-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/check-stale-putImageData-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/drawImage-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/fill-stroke-clip-reset-path-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/fillrect-gradient-zero-stops-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/patternfill-repeat-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/zero-size-fill-rect-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-before-css-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-bg-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-bg-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-resize-reset-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-transform-identity-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-transform-infinity-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-transform-multiply-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-transform-nan-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-transform-non-invertible-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/canvasDrawingIntoSelf-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/drawImage-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/fill-stroke-clip-reset-path-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/fillrect-gradient-zero-stops-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/patternfill-repeat-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/zero-size-fill-rect-expected.png View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
Justin Novosad
PTAL. Bye bye pixels :-P
6 years, 9 months ago (2014-03-05 19:06:17 UTC) #1
Stephen White
w00t! AWESOME! LGTM (nits are at your discretion). https://codereview.chromium.org/187393007/diff/1/LayoutTests/fast/canvas/canvas-transform-skewed.html File LayoutTests/fast/canvas/canvas-transform-skewed.html (right): https://codereview.chromium.org/187393007/diff/1/LayoutTests/fast/canvas/canvas-transform-skewed.html#newcode13 LayoutTests/fast/canvas/canvas-transform-skewed.html:13: // ...
6 years, 9 months ago (2014-03-05 21:29:32 UTC) #2
Justin Novosad
Committed patchset #1 manually as r168540 (presubmit successful).
6 years, 9 months ago (2014-03-05 22:19:36 UTC) #3
Justin Novosad
6 years, 9 months ago (2014-03-05 22:21:12 UTC) #4
Message was sent while issue was closed.
On 2014/03/05 22:19:36, junov wrote:
> Committed patchset #1 manually as r168540 (presubmit successful).

FYI Corrected all nits.

Powered by Google App Engine
This is Rietveld 408576698