Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1873663002: Convert //google_apis from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
CC:
chromium-reviews, johnme+watch_chromium.org, Peter Beverloo, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //google_apis from scoped_ptr to std::unique_ptr BUG=554298 Committed: https://crrev.com/f064cccace7bf4d940a494042754760f07e8164f Cr-Commit-Position: refs/heads/master@{#386115}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+730 lines, -689 lines) Patch
M google_apis/drive/auth_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/base_requests.h View 5 chunks +11 lines, -11 lines 0 comments Download
M google_apis/drive/base_requests.cc View 12 chunks +18 lines, -18 lines 2 comments Download
M google_apis/drive/base_requests_server_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M google_apis/drive/base_requests_unittest.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M google_apis/drive/drive_api_parser.h View 14 chunks +16 lines, -14 lines 0 comments Download
M google_apis/drive/drive_api_parser.cc View 13 chunks +41 lines, -37 lines 0 comments Download
M google_apis/drive/drive_api_parser_unittest.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M google_apis/drive/drive_api_requests.h View 10 chunks +20 lines, -16 lines 0 comments Download
M google_apis/drive/drive_api_requests.cc View 7 chunks +15 lines, -16 lines 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 42 chunks +63 lines, -65 lines 0 comments Download
M google_apis/drive/drive_common_callbacks.h View 2 chunks +3 lines, -2 lines 0 comments Download
M google_apis/drive/files_list_request_runner.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/drive/files_list_request_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/files_list_request_runner_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M google_apis/drive/request_sender.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/drive/request_util.h View 2 chunks +3 lines, -2 lines 0 comments Download
M google_apis/drive/request_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/drive/task_util.h View 3 chunks +13 lines, -9 lines 0 comments Download
M google_apis/drive/test_util.h View 5 chunks +7 lines, -7 lines 0 comments Download
M google_apis/drive/test_util.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M google_apis/gaia/account_tracker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gaia/account_tracker_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M google_apis/gaia/fake_gaia.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/fake_gaia.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_auth_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M google_apis/gaia/google_service_auth_error_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M google_apis/gaia/mock_url_fetcher_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl.cc View 4 chunks +13 lines, -10 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow.h View 3 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow_unittest.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow_unittest.cc View 7 chunks +10 lines, -9 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.h View 5 chunks +8 lines, -8 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request_unittest.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_unittest.cc View 26 chunks +61 lines, -72 lines 0 comments Download
M google_apis/gaia/ubertoken_fetcher.h View 2 chunks +4 lines, -3 lines 0 comments Download
M google_apis/gaia/ubertoken_fetcher_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M google_apis/gcm/base/mcs_message.h View 4 chunks +6 lines, -5 lines 0 comments Download
M google_apis/gcm/base/mcs_message.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M google_apis/gcm/base/mcs_message_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M google_apis/gcm/base/mcs_util.h View 2 chunks +5 lines, -5 lines 0 comments Download
M google_apis/gcm/base/mcs_util.cc View 5 chunks +18 lines, -16 lines 0 comments Download
M google_apis/gcm/base/mcs_util_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M google_apis/gcm/base/socket_stream_unittest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M google_apis/gcm/engine/checkin_request.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/checkin_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/connection_factory_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl_unittest.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M google_apis/gcm/engine/connection_handler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/connection_handler_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/connection_handler_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/connection_handler_impl_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M google_apis/gcm/engine/fake_connection_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/fake_connection_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/gcm_store.h View 2 chunks +5 lines, -5 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 14 chunks +16 lines, -16 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl_unittest.cc View 21 chunks +52 lines, -49 lines 0 comments Download
M google_apis/gcm/engine/heartbeat_manager.h View 3 chunks +4 lines, -3 lines 0 comments Download
M google_apis/gcm/engine/heartbeat_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M google_apis/gcm/engine/heartbeat_manager_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M google_apis/gcm/engine/mcs_client.h View 4 chunks +6 lines, -5 lines 0 comments Download
M google_apis/gcm/engine/mcs_client.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 12 chunks +20 lines, -19 lines 0 comments Download
M google_apis/gcm/engine/registration_request.h View 3 chunks +4 lines, -4 lines 0 comments Download
M google_apis/gcm/engine/registration_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/registration_request_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M google_apis/gcm/engine/unregistration_request.h View 3 chunks +5 lines, -4 lines 0 comments Download
M google_apis/gcm/engine/unregistration_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/unregistration_request_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 9 chunks +25 lines, -24 lines 0 comments Download
M google_apis/google_api_keys.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M google_apis/google_api_keys_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dcheng
This is largely a search and replace. There's probably some IWYU errors (files that don't ...
4 years, 8 months ago (2016-04-08 04:37:53 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/1873663002/diff/1/google_apis/drive/base_requests.cc File google_apis/drive/base_requests.cc (right): https://codereview.chromium.org/1873663002/diff/1/google_apis/drive/base_requests.cc#newcode297 google_apis/drive/base_requests.cc:297: buffer->data(), num_bytes))); Line formatting does not seem right ...
4 years, 8 months ago (2016-04-08 15:03:34 UTC) #4
dcheng
https://codereview.chromium.org/1873663002/diff/1/google_apis/drive/base_requests.cc File google_apis/drive/base_requests.cc (right): https://codereview.chromium.org/1873663002/diff/1/google_apis/drive/base_requests.cc#newcode297 google_apis/drive/base_requests.cc:297: buffer->data(), num_bytes))); On 2016/04/08 at 15:03:33, Roger Tawa wrote: ...
4 years, 8 months ago (2016-04-08 17:27:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873663002/1
4 years, 8 months ago (2016-04-08 17:28:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 17:35:54 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 17:38:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f064cccace7bf4d940a494042754760f07e8164f
Cr-Commit-Position: refs/heads/master@{#386115}

Powered by Google App Engine
This is Rietveld 408576698