Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 1873623002: [tools/perf] Make trybot bails out early if the benchmark is disabled on trybot platform (Closed)

Created:
4 years, 8 months ago by nednguyen
Modified:
4 years, 8 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Make trybot bails out early if the benchmark is disabled on trybot platform Note that this functionality only work to some certain extent since the disabling can be very dynamic & requires the actual hardware to know whether the benchmark is actually disabled. We bias on the side of not disabling the benchmark if we don't have enough information to tell & add a warning message telling users that the benchmark may be disabled. BUG=591410 Committed: https://crrev.com/1f209bc5e1f049ca2dad7ca1145a34332e3f27d7 Cr-Commit-Position: refs/heads/master@{#386410}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -8 lines) Patch
M tools/perf/core/trybot_command.py View 2 chunks +76 lines, -8 lines 0 comments Download
M tools/perf/core/trybot_command_unittest.py View 2 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
nednguyen
4 years, 8 months ago (2016-04-08 20:55:41 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873623002/40001
4 years, 8 months ago (2016-04-08 20:57:36 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-08 22:59:23 UTC) #9
sullivan
lgtm
4 years, 8 months ago (2016-04-11 15:43:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873623002/40001
4 years, 8 months ago (2016-04-11 15:52:03 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 8 months ago (2016-04-11 18:17:01 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 18:18:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f209bc5e1f049ca2dad7ca1145a34332e3f27d7
Cr-Commit-Position: refs/heads/master@{#386410}

Powered by Google App Engine
This is Rietveld 408576698