Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tools/perf/core/trybot_command_unittest.py

Issue 1873623002: [tools/perf] Make trybot bails out early if the benchmark is disabled on trybot platform (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/core/trybot_command.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/core/trybot_command_unittest.py
diff --git a/tools/perf/core/trybot_command_unittest.py b/tools/perf/core/trybot_command_unittest.py
index 76c7bb7223ddff30ae3325fd6d6e13035a46a946..4d7aa2bf3b934308eca6e49a7b8ba6f5214ee2a9 100644
--- a/tools/perf/core/trybot_command_unittest.py
+++ b/tools/perf/core/trybot_command_unittest.py
@@ -9,6 +9,7 @@ import unittest
import mock
+from telemetry import benchmark
from telemetry.testing import system_stub
from core import trybot_command
@@ -627,3 +628,54 @@ class TrybotCommandTest(unittest.TestCase):
"truncate_percent": "0"
}''')
self.assertEquals(cfg.read(), config)
+
+
+
+class IsBenchmarkDisabledOnTrybotPlatformTest(unittest.TestCase):
+
+ def IsBenchmarkDisabled(self, benchmark_class, trybot_name):
+ return trybot_command.Trybot.IsBenchmarkDisabledOnTrybotPlatform(
+ benchmark_class, trybot_name)[0]
+
+ def testBenchmarkIsDisabledAll(self):
+ @benchmark.Disabled('all')
+ class FooBenchmark(benchmark.Benchmark):
+ pass
+ self.assertTrue(self.IsBenchmarkDisabled(FooBenchmark, 'all'))
+ self.assertTrue(self.IsBenchmarkDisabled(FooBenchmark, 'all-mac'))
+ self.assertTrue(self.IsBenchmarkDisabled(FooBenchmark, 'android-s5'))
+ self.assertTrue(self.IsBenchmarkDisabled(FooBenchmark, 'linux'))
+ self.assertTrue(self.IsBenchmarkDisabled(FooBenchmark, 'winx64ati'))
+
+ def testBenchmarkIsEnabledAll(self):
+ @benchmark.Enabled('all')
+ class FooBenchmark(benchmark.Benchmark):
+ pass
+ self.assertFalse(self.IsBenchmarkDisabled(FooBenchmark, 'all'))
+ self.assertFalse(self.IsBenchmarkDisabled(FooBenchmark, 'all-mac'))
+ self.assertFalse(self.IsBenchmarkDisabled(FooBenchmark, 'android-s5'))
+ self.assertFalse(self.IsBenchmarkDisabled(FooBenchmark, 'linux'))
+ self.assertFalse(self.IsBenchmarkDisabled(FooBenchmark, 'winx64ati'))
+
+ def testBenchmarkIsDisabledOnMultiplePlatforms(self):
+ @benchmark.Disabled('win', 'mac')
+ class FooBenchmark(benchmark.Benchmark):
+ pass
+ self.assertFalse(self.IsBenchmarkDisabled(FooBenchmark, 'all'))
+ self.assertFalse(self.IsBenchmarkDisabled(FooBenchmark, 'android-s5'))
+ self.assertFalse(self.IsBenchmarkDisabled(FooBenchmark, 'linux'))
+
+ self.assertTrue(self.IsBenchmarkDisabled(FooBenchmark, 'all-mac'))
+ self.assertTrue(self.IsBenchmarkDisabled(FooBenchmark, 'winx64ati'))
+
+ def testBenchmarkIsEnabledOnMultiplePlatforms(self):
+ @benchmark.Enabled('win', 'mac')
+ class FooBenchmark(benchmark.Benchmark):
+ pass
+ self.assertFalse(self.IsBenchmarkDisabled(FooBenchmark, 'all'))
+ self.assertFalse(self.IsBenchmarkDisabled(FooBenchmark, 'all-mac'))
+ self.assertFalse(self.IsBenchmarkDisabled(FooBenchmark, 'winx64ati'))
+
+ self.assertTrue(self.IsBenchmarkDisabled(FooBenchmark, 'android-s5'))
+ self.assertTrue(self.IsBenchmarkDisabled(FooBenchmark, 'linux'))
+ self.assertTrue(self.IsBenchmarkDisabled(FooBenchmark, 'all-linux'))
« no previous file with comments | « tools/perf/core/trybot_command.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698