Issue 1873583002: Move isNavigationAllowed() check to main entry point for loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1873583002: Move isNavigationAllowed() check to main entry point for loads. (Closed)

Created:
4 years, 8 months ago by dcheng

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Move isNavigationAllowed() check to main entry point for loads. Also document the difference between the two types of navigation disablers and how they should be used. BUG=600182 Review URL: https://codereview.chromium.org/1858833003 Cr-Commit-Position: refs/heads/master@{#385306} (cherry picked from commit 73563fee12defb21a8f955993b68907169e1ea6d) Committed: https://chromium.googlesource.com/chromium/src/+/a3a744f56382c972e1627fe9ee03fbcab4923582

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -2 lines)			Patch
M	third_party/WebKit/Source/core/frame/LocalFrame.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/loader/FrameLoader.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/loader/NavigationScheduler.cpp	View	1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

dcheng

4 years, 8 months ago (2016-04-07 22:55:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a3a744f56382c972e1627fe9ee03fbcab4923582.