Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(57)

Issue 1858833003: Move isNavigationAllowed() check to main entry point for loads. (Closed)

Created:
3 years, 3 months ago by dcheng
Modified:
3 years, 3 months ago
CC:
Avi (use Gerrit), blink-reviews, chromium-reviews, clamy, gavinp+loader_chromium.org, Nate Chapin, kinuko, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move isNavigationAllowed() check to main entry point for loads. Also document the difference between the two types of navigation disablers and how they should be used. BUG=600182 Committed: https://crrev.com/73563fee12defb21a8f955993b68907169e1ea6d Cr-Commit-Position: refs/heads/master@{#385306}

Patch Set 1 #

Total comments: 1

Patch Set 2 : reflow comment #

Total comments: 3

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
dcheng
+japhet for primary review +avi, +clamy, +kinuko for FYI https://codereview.chromium.org/1858833003/diff/1/third_party/WebKit/Source/core/loader/FrameLoader.cpp File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right): https://codereview.chromium.org/1858833003/diff/1/third_party/WebKit/Source/core/loader/FrameLoader.cpp#newcode897 third_party/WebKit/Source/core/loader/FrameLoader.cpp:897: ...
3 years, 3 months ago (2016-04-05 00:06:29 UTC) #2
dcheng
Also... no test because of plugin dependency. Working on it =(
3 years, 3 months ago (2016-04-05 00:06:55 UTC) #3
Avi (use Gerrit)
https://codereview.chromium.org/1858833003/diff/20001/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp File third_party/WebKit/Source/core/loader/NavigationScheduler.cpp (right): https://codereview.chromium.org/1858833003/diff/20001/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp#newcode284 third_party/WebKit/Source/core/loader/NavigationScheduler.cpp:284: // 1. NavigationDisablerForBeforeUnload is for blocking navigation scheduling On ...
3 years, 3 months ago (2016-04-05 01:36:33 UTC) #5
dcheng
https://codereview.chromium.org/1858833003/diff/20001/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp File third_party/WebKit/Source/core/loader/NavigationScheduler.cpp (right): https://codereview.chromium.org/1858833003/diff/20001/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp#newcode284 third_party/WebKit/Source/core/loader/NavigationScheduler.cpp:284: // 1. NavigationDisablerForBeforeUnload is for blocking navigation scheduling On ...
3 years, 3 months ago (2016-04-05 04:47:22 UTC) #6
Nate Chapin
LGTM. Any hope of a test?
3 years, 3 months ago (2016-04-05 20:05:59 UTC) #7
dcheng
On 2016/04/05 at 20:05:59, japhet wrote: > LGTM. Any hope of a test? Working on ...
3 years, 3 months ago (2016-04-05 20:07:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858833003/20001
3 years, 3 months ago (2016-04-05 21:06:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/205976)
3 years, 3 months ago (2016-04-05 21:11:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858833003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858833003/40001
3 years, 3 months ago (2016-04-05 21:15:17 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 3 months ago (2016-04-05 22:39:39 UTC) #16
commit-bot: I haz the power
3 years, 3 months ago (2016-04-05 22:41:05 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/73563fee12defb21a8f955993b68907169e1ea6d
Cr-Commit-Position: refs/heads/master@{#385306}

Powered by Google App Engine
This is Rietveld 408576698