|
|
Chromium Code Reviews|
Created:
4 years, 8 months ago by cpaulin (no longer in chrome) Modified:
4 years, 8 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org, emircan Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTelemetry: Added a new page set to webrtc.webrtc_smoothness
This CL adds a new page set for webrtc.webrtc_smoothness related
to canvas capture. Basically we perform a local peer connection
with source stream being a canvas captured stream.
BUG=601534
TEST= On linux workstation and bots
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
Committed: https://crrev.com/1531a18162d9db45cb9f66886ada44c0fafa6c62
Cr-Commit-Position: refs/heads/master@{#387723}
Patch Set 1 : Added canvas capture page set to webrtc.webrtc_smoothness #
Total comments: 2
Patch Set 2 : Addressed cosmetic comment from phoglund@ #Patch Set 3 : Disabled reference run on perf cq bots #
Messages
Total messages: 35 (19 generated)
Description was changed from ========== Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG= 601534 TEST= On linuz workstation and bots ========== to ========== Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG= 601534 TEST= On linuz workstation and bots CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
Description was changed from ========== Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG= 601534 TEST= On linuz workstation and bots CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG= 601534 TEST= On linuz workstation and bots CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
cpaulin@chromium.org changed reviewers: + nednguyen@google.com, phoglund@chromium.org
Hi all, Please review the canvas capture page set addition to webrtc.webrtc_smoothness This enables us to track canvas capture performance.
Description was changed from ========== Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG= 601534 TEST= On linuz workstation and bots CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG= 601534 TEST= On linux workstation and bots CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
Patchset #1 (id:1) has been deleted
owner stamp lgtm but please make phoglund happy.
lgtm https://codereview.chromium.org/1873503002/diff/20001/tools/perf/page_sets/we... File tools/perf/page_sets/webrtc_cases.py (right): https://codereview.chromium.org/1873503002/diff/20001/tools/perf/page_sets/we... tools/perf/page_sets/webrtc_cases.py:11: CANVAS_CAPTURE_URL = ('https://rawgit.com/cricdecyan/mediarecorder/master/' Maybe call it MEDIARECORDER_GIT_URL, and assign it 'https://rawgit.com/cricdecyan/mediarecorder/master/'. You can add the rest of the path in Page8 similar to how the other pages do it.
Addressed minor comment from phoglund@ https://codereview.chromium.org/1873503002/diff/20001/tools/perf/page_sets/we... File tools/perf/page_sets/webrtc_cases.py (right): https://codereview.chromium.org/1873503002/diff/20001/tools/perf/page_sets/we... tools/perf/page_sets/webrtc_cases.py:11: CANVAS_CAPTURE_URL = ('https://rawgit.com/cricdecyan/mediarecorder/master/' On 2016/04/08 11:50:22, phoglund_chrome wrote: > Maybe call it MEDIARECORDER_GIT_URL, and assign it > 'https://rawgit.com/cricdecyan/mediarecorder/master/'. You can add the rest of > the path in Page8 similar to how the other pages do it. Done.
The CQ bit was checked by cpaulin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, phoglund@chromium.org Link to the patchset: https://codereview.chromium.org/1873503002/#ps40001 (title: "Addressed cosmetic comment from phoglund@")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873503002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_cq/bu...) mac_retina_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...)
The CQ bit was checked by cpaulin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com, phoglund@chromium.org Link to the patchset: https://codereview.chromium.org/1873503002/#ps60001 (title: "Disabled reference run on perf cq bots")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873503002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
The CQ bit was checked by cpaulin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873503002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
The CQ bit was checked by cpaulin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873503002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
On 2016/04/15 19:13:08, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...) The way you skip android_s5_perf_cq is by removing "tryserver.chromium.perf:android_s5_perf_cq;" text from CQ_EXTRA_TRYBOT in the description.
Description was changed from ========== Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG= 601534 TEST= On linux workstation and bots CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG= 601534 TEST= On linux workstation and bots CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
The CQ bit was checked by cpaulin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873503002/60001
Message was sent while issue was closed.
Description was changed from ========== Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG= 601534 TEST= On linux workstation and bots CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG= 601534 TEST= On linux workstation and bots CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG= 601534 TEST= On linux workstation and bots CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG= 601534 TEST= On linux workstation and bots CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/1531a18162d9db45cb9f66886ada44c0fafa6c62 Cr-Commit-Position: refs/heads/master@{#387723} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/1531a18162d9db45cb9f66886ada44c0fafa6c62 Cr-Commit-Position: refs/heads/master@{#387723} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
