Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1873503002: Telemetry: Added a new page set to webrtc.webrtc_smoothness (Closed)

Created:
4 years, 8 months ago by cpaulin (no longer in chrome)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, emircan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Added a new page set to webrtc.webrtc_smoothness This CL adds a new page set for webrtc.webrtc_smoothness related to canvas capture. Basically we perform a local peer connection with source stream being a canvas captured stream. BUG=601534 TEST= On linux workstation and bots CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Committed: https://crrev.com/1531a18162d9db45cb9f66886ada44c0fafa6c62 Cr-Commit-Position: refs/heads/master@{#387723}

Patch Set 1 : Added canvas capture page set to webrtc.webrtc_smoothness #

Total comments: 2

Patch Set 2 : Addressed cosmetic comment from phoglund@ #

Patch Set 3 : Disabled reference run on perf cq bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -43 lines) Patch
M tools/perf/benchmarks/webrtc.py View 1 2 5 chunks +8 lines, -4 lines 0 comments Download
A + tools/perf/page_sets/data/webrtc_smoothness_cases.json View 1 chunk +3 lines, -2 lines 0 comments Download
A tools/perf/page_sets/data/webrtc_smoothness_cases_001.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/webrtc_cases.py View 1 9 chunks +68 lines, -37 lines 0 comments Download

Messages

Total messages: 35 (19 generated)
cpaulin (no longer in chrome)
Hi all, Please review the canvas capture page set addition to webrtc.webrtc_smoothness This enables us ...
4 years, 8 months ago (2016-04-07 18:53:09 UTC) #4
nednguyen
owner stamp lgtm but please make phoglund happy.
4 years, 8 months ago (2016-04-07 19:19:01 UTC) #7
phoglund_chromium
lgtm https://codereview.chromium.org/1873503002/diff/20001/tools/perf/page_sets/webrtc_cases.py File tools/perf/page_sets/webrtc_cases.py (right): https://codereview.chromium.org/1873503002/diff/20001/tools/perf/page_sets/webrtc_cases.py#newcode11 tools/perf/page_sets/webrtc_cases.py:11: CANVAS_CAPTURE_URL = ('https://rawgit.com/cricdecyan/mediarecorder/master/' Maybe call it MEDIARECORDER_GIT_URL, and ...
4 years, 8 months ago (2016-04-08 11:50:22 UTC) #8
cpaulin (no longer in chrome)
Addressed minor comment from phoglund@ https://codereview.chromium.org/1873503002/diff/20001/tools/perf/page_sets/webrtc_cases.py File tools/perf/page_sets/webrtc_cases.py (right): https://codereview.chromium.org/1873503002/diff/20001/tools/perf/page_sets/webrtc_cases.py#newcode11 tools/perf/page_sets/webrtc_cases.py:11: CANVAS_CAPTURE_URL = ('https://rawgit.com/cricdecyan/mediarecorder/master/' On ...
4 years, 8 months ago (2016-04-08 18:01:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873503002/40001
4 years, 8 months ago (2016-04-08 18:02:25 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_cq/builds/105) mac_retina_perf_cq on tryserver.chromium.perf (JOB_FAILED, ...
4 years, 8 months ago (2016-04-08 19:22:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873503002/60001
4 years, 8 months ago (2016-04-13 22:21:55 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/140)
4 years, 8 months ago (2016-04-13 23:29:46 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873503002/60001
4 years, 8 months ago (2016-04-14 22:34:45 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/144)
4 years, 8 months ago (2016-04-15 01:02:29 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873503002/60001
4 years, 8 months ago (2016-04-15 16:52:53 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/148)
4 years, 8 months ago (2016-04-15 19:13:08 UTC) #27
nednguyen
On 2016/04/15 19:13:08, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-15 20:05:13 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873503002/60001
4 years, 8 months ago (2016-04-15 22:15:50 UTC) #31
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 8 months ago (2016-04-15 22:22:11 UTC) #33
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 22:23:42 UTC) #35
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1531a18162d9db45cb9f66886ada44c0fafa6c62
Cr-Commit-Position: refs/heads/master@{#387723}

Powered by Google App Engine
This is Rietveld 408576698