Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: tools/perf/benchmarks/webrtc.py

Issue 1873503002: Telemetry: Added a new page set to webrtc.webrtc_smoothness (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disabled reference run on perf cq bots Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/data/webrtc_smoothness_cases.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/webrtc.py
diff --git a/tools/perf/benchmarks/webrtc.py b/tools/perf/benchmarks/webrtc.py
index d20c237737306be5122b8facfacf251f1579c194..c77850a28e74654cda13c1b6ea874ff740ee1ca7 100644
--- a/tools/perf/benchmarks/webrtc.py
+++ b/tools/perf/benchmarks/webrtc.py
@@ -17,6 +17,7 @@ RENDERING_VALUE_PREFIX = 'WebRTCRendering_'
# is fixed, or revert https://codereview.chromium.org/1544573002/ when
# http://crbug.com/568333 is fixed.
+
# Disabled because the reference set becomes flaky with the new
# https:// page set introduced in http://crbug.com/523517.
# Try removing once the Chrome used for ref builds advances
@@ -28,7 +29,7 @@ class _Webrtc(perf_benchmark.PerfBenchmark):
class WebrtcGetusermedia(_Webrtc):
- """Measures WebRtc GetUserMedia for video capture and local playback"""
+ """Measures WebRtc GetUserMedia for video capture and local playback."""
page_set = page_sets.WebrtcGetusermediaPageSet
@classmethod
@@ -37,7 +38,7 @@ class WebrtcGetusermedia(_Webrtc):
class WebrtcPeerConnection(_Webrtc):
- """Measures WebRtc Peerconnection for remote video and audio communication """
+ """Measures WebRtc Peerconnection for remote video and audio communication."""
page_set = page_sets.WebrtcPeerconnectionPageSet
@classmethod
@@ -46,7 +47,7 @@ class WebrtcPeerConnection(_Webrtc):
class WebrtcDataChannel(_Webrtc):
- """Measures WebRtc DataChannel loopback """
+ """Measures WebRtc DataChannel loopback."""
page_set = page_sets.WebrtcDatachannelPageSet
@classmethod
@@ -56,10 +57,13 @@ class WebrtcDataChannel(_Webrtc):
# WebrtcRendering must be a PerfBenchmark, and not a _Webrtc, because it is a
# timeline-based.
+# Disabled on reference builds because they crash and don't support tab
+# capture. See http://crbug.com/603232.
+@benchmark.Disabled('reference')
class WebrtcRendering(perf_benchmark.PerfBenchmark):
"""Specific time measurements (e.g. fps, smoothness) for WebRtc rendering."""
- page_set = page_sets.WebrtcPeerconnectionPageSet
+ page_set = page_sets.WebrtcRenderingPageSet
def CreateTimelineBasedMeasurementOptions(self):
category_filter = tracing_category_filter.TracingCategoryFilter(
« no previous file with comments | « no previous file | tools/perf/page_sets/data/webrtc_smoothness_cases.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698