Improved diagnostic message for JS heap out of memory

Improved diagnostic message for JS heap out of memory

This patch replaces the unused 'take_snapshot' parameter on FatalProcessOutOfMemory()
with a 'is_heap_oom' parameter. The parameter is set to true on error paths where the
JS heap is out of memory, as distinct from a malloc() failure i.e. process out of memory.
The message output to stderr or passed to embedding applications via FatalErrorCallback
is 'Javascript heap out of memory' rather than 'process out of memory'.

BUG=

R=jochen@chromium.org, verwaest@chromium.org, michael_dawson@ca.ibm.com

Committed: https://crrev.com/1ef7487b657e4b1a86cf778ac062b25de5001af7
Cr-Commit-Position: refs/heads/master@{#35431}

[Richard Chamberlain, 2016-04-07 15:15:02]

Submitting for review again (new issue, under correct ibm.com account) - thanks

[Hannes Payer (out of office), 2016-04-07 17:09:23]

hpayer@chromium.org changed reviewers:
+ hpayer@chromium.org

[Hannes Payer (out of office), 2016-04-07 17:09:24]

lgtm with one nit

https://codereview.chromium.org/1873443002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1873443002/diff/1/src/api.cc#newcode307
src/api.cc:307: Utils::ApiCheck(false, location,
Please change to:
Utils::ApiCheck(false, location, is_heap_oom ? "Allocation failed - JavaScript
heap out of memory" : "Allocation failed - process out of memory");

[Richard Chamberlain, 2016-04-08 13:52:35]

On 2016/04/07 17:09:24, Hannes Payer wrote:
> lgtm with one nit
> 
> https://codereview.chromium.org/1873443002/diff/1/src/api.cc
> File src/api.cc (right):
> 
> https://codereview.chromium.org/1873443002/diff/1/src/api.cc#newcode307
> src/api.cc:307: Utils::ApiCheck(false, location,
> Please change to:
> Utils::ApiCheck(false, location, is_heap_oom ? "Allocation failed - JavaScript
> heap out of memory" : "Allocation failed - process out of memory");

Done, see patch set #2

[jochen (gone - plz use gerrit), 2016-04-08 22:30:33]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-04-08 22:30:34]

lgtm

[jochen (gone - plz use gerrit), 2016-04-08 22:30:34]

The patchset sent to the CQ was uploaded after l-g-t-m from hpayer@chromium.org
Link to the patchset: https://codereview.chromium.org/1873443002/#ps20001
(title: "Code review fix, use ternary operator")

[commit-bot: I haz the power, 2016-04-08 22:30:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1873443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1873443002/20001

[commit-bot: I haz the power, 2016-04-08 22:30:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 22:30:46]

The author richard_chamberlain@uk.ibm.com has not signed Google Contributor
License Agreement. Please visit https://cla.developers.google.com to sign and
manage CLA.

[Richard Chamberlain, 2016-04-12 08:36:59]

The CQ bit was checked by richard_chamberlain@uk.ibm.com

[commit-bot: I haz the power, 2016-04-12 08:37:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1873443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1873443002/20001

[commit-bot: I haz the power, 2016-04-12 08:40:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-12 08:40:56]

Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)

[Richard Chamberlain, 2016-04-13 08:06:24]

The CQ bit was checked by richard_chamberlain@uk.ibm.com

[commit-bot: I haz the power, 2016-04-13 08:06:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1873443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1873443002/20001

[commit-bot: I haz the power, 2016-04-13 08:26:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-13 08:27:44]

Description was changed from

==========
Improved diagnostic message for JS heap out of memory

This patch replaces the unused 'take_snapshot' parameter on
FatalProcessOutOfMemory()
with a 'is_heap_oom' parameter. The parameter is set to true on error paths
where the
JS heap is out of memory, as distinct from a malloc() failure i.e. process out
of memory.
The message output to stderr or passed to embedding applications via
FatalErrorCallback
is 'Javascript heap out of memory' rather than 'process out of memory'.

BUG=

R=jochen@chromium.org, verwaest@chromium.org, michael_dawson@ca.ibm.com
==========

to

==========
Improved diagnostic message for JS heap out of memory

This patch replaces the unused 'take_snapshot' parameter on
FatalProcessOutOfMemory()
with a 'is_heap_oom' parameter. The parameter is set to true on error paths
where the
JS heap is out of memory, as distinct from a malloc() failure i.e. process out
of memory.
The message output to stderr or passed to embedding applications via
FatalErrorCallback
is 'Javascript heap out of memory' rather than 'process out of memory'.

BUG=

R=jochen@chromium.org, verwaest@chromium.org, michael_dawson@ca.ibm.com

Committed: https://crrev.com/1ef7487b657e4b1a86cf778ac062b25de5001af7
Cr-Commit-Position: refs/heads/master@{#35431}
==========

[commit-bot: I haz the power, 2016-04-13 08:27:45]

Patchset 2 (id:??) landed as
https://crrev.com/1ef7487b657e4b1a86cf778ac062b25de5001af7
Cr-Commit-Position: refs/heads/master@{#35431}