src/heap/heap.h - Issue 1873443002: Improved diagnostic message for JS heap out of memory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.h

Issue 1873443002: Improved diagnostic message for JS heap out of memory (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Code review fix, use ternary operator Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/heap.h

diff --git a/src/heap/heap.h b/src/heap/heap.h

index 59d7dfcf002f9229018a4965cdc0617eeef70541..22846625095a7ce55eec0f194aa4283449540b70 100644

--- a/src/heap/heap.h

+++ b/src/heap/heap.h

@@ -566,7 +566,7 @@ class Heap {

static inline bool IsOneByte(T t, int chars);

static void FatalProcessOutOfMemory(const char* location,

- bool take_snapshot = false);

+ bool is_heap_oom = false);

static bool RootIsImmortalImmovable(int root_index);

« no previous file with comments | « src/api.cc ('k') | src/heap/heap.cc » ('j') | no next file with comments »