Issue 1873393002: Fix VAO restore in CopyTextureCHROMIUM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1873393002: Fix VAO restore in CopyTextureCHROMIUM. (Closed)

Created:
4 years, 8 months ago by Zhenyao Mo

Modified:
4 years, 8 months ago

Reviewers:
Zhenyao Mo

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Fix VAO restore in CopyTextureCHROMIUM. Restoring all attributes on devices that don't support VAOs is causing black tiles. Removing the restore, which isn't needed in that case. R=zmo@chromium.org BUG=586912 BUG=532708 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1876213002 Cr-Commit-Position: refs/heads/master@{#386462} (cherry picked from commit afe9337f8bb71c59172a24ce0b80fd999d098e66) Committed: https://chromium.googlesource.com/chromium/src/+/c7701bdf4e5e3dc87ad632f0a4f3df2922e904e9

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Zhenyao Mo

4 years, 8 months ago (2016-04-11 22:35:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c7701bdf4e5e3dc87ad632f0a4f3df2922e904e9.