Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1876213002: Fix VAO restore in CopyTextureCHROMIUM. (Closed)

Created:
4 years, 8 months ago by vmiura
Modified:
4 years, 8 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix VAO restore in CopyTextureCHROMIUM. Restoring all attributes on devices that don't support VAOs is causing black tiles. Removing the restore, which isn't needed in that case. R=zmo@chromium.org BUG=586912 BUG=532708 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/afe9337f8bb71c59172a24ce0b80fd999d098e66 Cr-Commit-Position: refs/heads/master@{#386462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
vmiura
ptal
4 years, 8 months ago (2016-04-11 18:00:49 UTC) #2
Zhenyao Mo
On 2016/04/11 18:00:49, vmiura wrote: > ptal lgtm
4 years, 8 months ago (2016-04-11 18:01:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876213002/1
4 years, 8 months ago (2016-04-11 18:01:46 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 19:27:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1876213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1876213002/1
4 years, 8 months ago (2016-04-11 20:26:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 20:34:17 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 20:36:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afe9337f8bb71c59172a24ce0b80fd999d098e66
Cr-Commit-Position: refs/heads/master@{#386462}

Powered by Google App Engine
This is Rietveld 408576698