Issue 187333002: android: Remove unused 'inputs' parameter for finalize_apk_action.gypi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 187333002: android: Remove unused 'inputs' parameter for finalize_apk_action.gypi. (Closed)

Created:
6 years, 9 months ago by Nico

Modified:
6 years, 9 months ago

Reviewers:
cjhopman

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, wjia(left Chromium)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

android: Remove unused 'inputs' parameter for finalize_apk_action.gypi. This allows removing a now-unneeded md5sum invocation too, which in turn allows removing finalize_apk.py's --ignored parameter. No intended behavior change. BUG=177552 R=cjhopman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255114

Patch Set 1 #

Patch Set 2 : . #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	build/android/finalize_apk_action.gypi	View		4 chunks	+0 lines, -6 lines	0 comments	Download
	M	build/android/gyp/finalize_apk.py	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

The inputs parameter was added in the CL that added this gypi file ( https://codereview.chromium.org/17569006/ ...

6 years, 9 months ago (2014-03-05 01:43:56 UTC) #1

cjhopman

Can the option also be removed from build/android/gyp/finalize_apk.py?

6 years, 9 months ago (2014-03-05 01:56:00 UTC) #2

Nico

6 years, 9 months ago (2014-03-05 19:41:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r255114 (presubmit successful).

Expand Messages | Collapse Messages