Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: build/android/finalize_apk_action.gypi

Issue 187333002: android: Remove unused 'inputs' parameter for finalize_apk_action.gypi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/gyp/finalize_apk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/finalize_apk_action.gypi
diff --git a/build/android/finalize_apk_action.gypi b/build/android/finalize_apk_action.gypi
index b88bbba2cc7e40f855fd8c22b5915cf72df3e010..52aaa93ed53be1b3b4c8af79a922695360118518 100644
--- a/build/android/finalize_apk_action.gypi
+++ b/build/android/finalize_apk_action.gypi
@@ -9,7 +9,6 @@
# {
# 'action_name': 'some descriptive action name',
# 'variables': {
-# 'inputs': [ 'input_path1', 'input_path2' ],
# 'input_apk_path': 'relative/path/to/input.apk',
# 'output_apk_path': 'relative/path/to/output.apk',
# },
@@ -20,7 +19,6 @@
{
'message': 'Signing/aligning <(_target_name) APK: <(input_apk_path)',
'variables': {
- 'inputs': [],
'keystore_path%': '<(DEPTH)/build/android/ant/chromium-debug.keystore',
},
'inputs': [
@@ -28,7 +26,6 @@
'<(DEPTH)/build/android/gyp/finalize_apk.py',
'<(keystore_path)',
'<(input_apk_path)',
- '>@(inputs)',
],
'outputs': [
'<(output_apk_path)',
@@ -39,8 +36,5 @@
'--unsigned-apk-path=<(input_apk_path)',
'--final-apk-path=<(output_apk_path)',
'--keystore-path=<(keystore_path)',
-
- # TODO(newt): remove this once crbug.com/177552 is fixed in ninja.
- '--ignore=>!(echo \'>(_inputs)\' | md5sum)',
],
}
« no previous file with comments | « no previous file | build/android/gyp/finalize_apk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698