third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py - Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

Issue 1873323002: Have bindings layer assume and insist that all interface types are GCed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h ('k') | third_party/WebKit/Source/bindings/scripts/interface_dependency_resolver.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

diff --git a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

index cdfeaaffe08581f6aec19f9ad2c5422e462a029a..3e4270294ebbaf3c9ceb30a64099d596e4263c5a 100755

--- a/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

+++ b/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py

@@ -91,7 +91,6 @@ from utilities import idl_filename_to_component, read_pickle_files, write_pickle

INHERITED_EXTENDED_ATTRIBUTES = set([

'ActiveScriptWrappable',

'DependentLifetime',

- 'GarbageCollected',

])

# Main variable (filled in and exported)

@@ -184,8 +183,7 @@ def compute_global_type_info():

implemented_as_interfaces[interface_name] = interface_info['implemented_as']

inherited_extended_attributes = interface_info['inherited_extended_attributes']

- if 'GarbageCollected' in inherited_extended_attributes:

- garbage_collected_interfaces.add(interface_name)

+ garbage_collected_interfaces.add(interface_name)

interfaces_info['ancestors'] = ancestors

interfaces_info['callback_interfaces'] = callback_interfaces