Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1873133002: [GN] Fix -g flags to be consistent between gyp & gn on iOS. (Closed)

Created:
4 years, 8 months ago by sdefresne
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Fix -g flags to be consistent between gyp & gn on iOS. The gyp build uses -gdwarf-2 debug level so change GN to also use that level instead of -g2 when targetting iOS. BUG=None Committed: https://crrev.com/fa0530bfbfe97a969c23a00cb56d4f8d409c5eb9 Cr-Commit-Position: refs/heads/master@{#386656}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
sdefresne
Please take a look.
4 years, 8 months ago (2016-04-11 09:19:42 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/1873133002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/1873133002/diff/1/build/config/compiler/BUILD.gn#newcode1341 build/config/compiler/BUILD.gn:1341: if (!is_ios) { nit: I probably would've flipped ...
4 years, 8 months ago (2016-04-11 16:23:00 UTC) #3
sdefresne
https://codereview.chromium.org/1873133002/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/1873133002/diff/1/build/config/compiler/BUILD.gn#newcode1341 build/config/compiler/BUILD.gn:1341: if (!is_ios) { On 2016/04/11 at 16:23:00, Dirk Pranke ...
4 years, 8 months ago (2016-04-12 11:28:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873133002/20001
4 years, 8 months ago (2016-04-12 11:28:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-12 12:07:07 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 12:08:21 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fa0530bfbfe97a969c23a00cb56d4f8d409c5eb9
Cr-Commit-Position: refs/heads/master@{#386656}

Powered by Google App Engine
This is Rietveld 408576698