Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1873133002: [GN] Fix -g flags to be consistent between gyp & gn on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 1320 matching lines...) Expand 10 before | Expand all | Expand 10 after
1331 } 1331 }
1332 if (is_win_fastlink && visual_studio_version != "2013") { 1332 if (is_win_fastlink && visual_studio_version != "2013") {
1333 # Tell VS 2015+ to create a PDB that references debug 1333 # Tell VS 2015+ to create a PDB that references debug
1334 # information in .obj and .lib files instead of copying 1334 # information in .obj and .lib files instead of copying
1335 # it all. This flag is incompatible with /PROFILE 1335 # it all. This flag is incompatible with /PROFILE
1336 ldflags = [ "/DEBUG:FASTLINK" ] 1336 ldflags = [ "/DEBUG:FASTLINK" ]
1337 } else { 1337 } else {
1338 ldflags = [ "/DEBUG" ] 1338 ldflags = [ "/DEBUG" ]
1339 } 1339 }
1340 } else { 1340 } else {
1341 cflags = [ "-g2" ] 1341 if (is_ios) {
1342 cflags = [ "-gdwarf-2" ]
1343 } else {
1344 cflags = [ "-g2" ]
1345 }
1342 if (use_debug_fission) { 1346 if (use_debug_fission) {
1343 cflags += [ "-gsplit-dwarf" ] 1347 cflags += [ "-gsplit-dwarf" ]
1344 } 1348 }
1345 asmflags = cflags 1349 asmflags = cflags
1346 ldflags = [] 1350 ldflags = []
1347 } 1351 }
1348 } 1352 }
1349 1353
1350 # Minimal symbols. 1354 # Minimal symbols.
1351 config("minimal_symbols") { 1355 config("minimal_symbols") {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
1393 1397
1394 if (is_ios || is_mac) { 1398 if (is_ios || is_mac) {
1395 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1399 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1396 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1400 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1397 config("enable_arc") { 1401 config("enable_arc") {
1398 common_flags = [ "-fobjc-arc" ] 1402 common_flags = [ "-fobjc-arc" ]
1399 cflags_objc = common_flags 1403 cflags_objc = common_flags
1400 cflags_objcc = common_flags 1404 cflags_objcc = common_flags
1401 } 1405 }
1402 } 1406 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698