Reimplemented string array resources.

Reimplemented string array resources.

BUG=270362
R=lambroslambrou@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255669

[Jamie, 2014-03-05 20:51:31]

The web-app doesn't notify the user of the various stages of connection, and I
think it's better to be consistent here too. It saves us defining new strings
for the various protocol stages, and I think it simplifies the code as well.

PTAL.

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (left):

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:391:
Toast.makeText(this, stateText, Toast.LENGTH_SHORT).show();
I think this is unnecessary, although it might not always be obvious that you
are connected, for example if the screen is blanked. LMK if you'd like me to
reinstate it.

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:232:
mProgressIndicator = ProgressDialog.show(this,
Any reason not to create the progress dialog before the first state change
notification, while the host name is available?

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
(left):

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:21:
import android.widget.Toast;
Unused import.

https://codereview.chromium.org/187313007/diff/1/remoting/resources/android/v...
File remoting/resources/android/values/strings.xml (right):

https://codereview.chromium.org/187313007/diff/1/remoting/resources/android/v...
remoting/resources/android/values/strings.xml:9: <resources>
This file is now empty. Can it be removed?

[Lambros, 2014-03-05 23:36:54]

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:232:
mProgressIndicator = ProgressDialog.show(this,
On 2014/03/05 20:51:31, Jamie wrote:
> Any reason not to create the progress dialog before the first state change
> notification, while the host name is available?

I think that's fine.

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
(right):

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:101:
public int toResourceId() {
Make this a public final member of the enum instead. See for example:
chrome/android/java/src/org/chromium/chrome/browser/sync/GoogleServiceAuthError.java

https://codereview.chromium.org/187313007/diff/1/remoting/protocol/connection...
File remoting/protocol/connection_to_host.h (right):

https://codereview.chromium.org/187313007/diff/1/remoting/protocol/connection...
remoting/protocol/connection_to_host.h:55: // enumeration in
webapp/client_session.js,
nit: "and" instead of comma

https://codereview.chromium.org/187313007/diff/1/remoting/resources/android/v...
File remoting/resources/android/values/strings.xml (right):

https://codereview.chromium.org/187313007/diff/1/remoting/resources/android/v...
remoting/resources/android/values/strings.xml:9: <resources>
On 2014/03/05 20:51:31, Jamie wrote:
> This file is now empty. Can it be removed?

Yes, please remove it. Resource files can freely be added and removed here
without editing any GYP files.

[Lambros, 2014-03-05 23:56:35]

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (left):

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:391:
Toast.makeText(this, stateText, Toast.LENGTH_SHORT).show();
On 2014/03/05 20:51:31, Jamie wrote:
> I think this is unnecessary, although it might not always be obvious that you
> are connected, for example if the screen is blanked. LMK if you'd like me to
> reinstate it.

If we maybe change the title (or subtitle) of this screen to the name of the
connected host, I think we won't need this tooltip anyway. Fine to remove it for
now.

[Jamie, 2014-03-06 01:29:32]

ptal

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (left):

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:391:
Toast.makeText(this, stateText, Toast.LENGTH_SHORT).show();
On 2014/03/05 23:56:36, Lambros wrote:
> On 2014/03/05 20:51:31, Jamie wrote:
> > I think this is unnecessary, although it might not always be obvious that
you
> > are connected, for example if the screen is blanked. LMK if you'd like me to
> > reinstate it.
> 
> If we maybe change the title (or subtitle) of this screen to the name of the
> connected host, I think we won't need this tooltip anyway. Fine to remove it
for
> now.

Do you want me to make that change in this CL, or leave it for now?

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
(right):

https://codereview.chromium.org/187313007/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java:101:
public int toResourceId() {
On 2014/03/05 23:36:54, Lambros wrote:
> Make this a public final member of the enum instead. See for example:
>
chrome/android/java/src/org/chromium/chrome/browser/sync/GoogleServiceAuthError.java

I made it private instead, with an accessor for consistency with the |value|
member.

https://codereview.chromium.org/187313007/diff/1/remoting/protocol/connection...
File remoting/protocol/connection_to_host.h (right):

https://codereview.chromium.org/187313007/diff/1/remoting/protocol/connection...
remoting/protocol/connection_to_host.h:55: // enumeration in
webapp/client_session.js,
On 2014/03/05 23:36:54, Lambros wrote:
> nit: "and" instead of comma

Done.

https://codereview.chromium.org/187313007/diff/1/remoting/resources/android/v...
File remoting/resources/android/values/strings.xml (right):

https://codereview.chromium.org/187313007/diff/1/remoting/resources/android/v...
remoting/resources/android/values/strings.xml:9: <resources>
On 2014/03/05 23:36:54, Lambros wrote:
> On 2014/03/05 20:51:31, Jamie wrote:
> > This file is now empty. Can it be removed?
> 
> Yes, please remove it. Resource files can freely be added and removed here
> without editing any GYP files.

Done.

[Lambros, 2014-03-06 01:54:06]

lgtm

[Jamie, 2014-03-07 18:33:28]

Committed patchset #5 manually as r255669 (presubmit successful).