Reimplemented string array resources.

remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting.jni;
 
 import android.app.Activity;
 import android.app.AlertDialog;
 import android.content.Context;
 import android.content.DialogInterface;
 import android.content.SharedPreferences;
 import android.graphics.Bitmap;
 import android.graphics.Point;
 import android.os.Build;
 import android.os.Looper;
 import android.util.Log;
 import android.view.KeyEvent;
 import android.view.View;
 import android.widget.CheckBox;
 import android.widget.TextView;
-import android.widget.Toast;

[Jamie, 2014/03/05 20:51:31]

Unused import.

 
 import org.chromium.base.CalledByNative;
 import org.chromium.base.JNINamespace;
 import org.chromium.chromoting.R;
 
 import java.nio.ByteBuffer;
 import java.nio.ByteOrder;
 
 /**
  * Initializes the Chromium remoting library, and provides JNI calls into it.
@@ skipping 59 matching lines @@
                 mValue = value;
             }
 
             public int value() {
                 return mValue;
             }
 
             public static Error fromValue(int value) {
                 return values()[value];
             }
+
+            public int toResourceId() {

[Lambros, 2014/03/05 23:36:54]

Make this a public final member of the enum instead. See for example:
chrome/android/java/src/org/chromium/chrome/browser/sync/GoogleServiceAuthError.java

[Jamie, 2014/03/06 01:29:32]

I made it private instead, with an accessor for consistency with the |value|
member.

+                switch (this) {
+                    case PEER_IS_OFFLINE:
+                        return R.string.error_host_is_offline;
+                    case SESSION_REJECTED:
+                    case AUTHENTICATION_FAILED:
+                        return R.string.error_invalid_access_code;
+                    case INCOMPATIBLE_PROTOCOL:
+                        return R.string.error_incompatible_protocol;
+                    case HOST_OVERLOAD:
+                        return R.string.error_host_overload;
+                    case CHANNEL_CONNECTION_ERROR:
+                    case SIGNALING_ERROR:
+                    case SIGNALING_TIMEOUT:
+                        return R.string.error_p2p_failure;
+                    default:
+                        return R.string.error_unexpected;
+                }
+            }
         }
 
+
         /**
          * Notified on connection state change.
          * @param state The new connection state.
          * @param error The error code, if state is STATE_FAILED.
          */
         void onConnectionState(State state, Error error);
     }
 
     /*
      * Connection-initiating state machine.
@@ skipping 295 matching lines @@
         buffer.asIntBuffer().get(data, 0, data.length);
         sCursorBitmap = Bitmap.createBitmap(data, width, height, Bitmap.Config.ARGB_8888);
     }
 
     /** Position of cursor hotspot within cursor image. Called on the graphics thread. */
     public static Point getCursorHotspot() { return sCursorHotspot; }
 
     /** Returns the current cursor shape. Called on the graphics thread. */
     public static Bitmap getCursorBitmap() { return sCursorBitmap; }
 }