Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: server/logdog/storage/storage.go

Issue 1872903002: LogDog: Enable keys-only BigTable queries. (Closed) Base URL: https://github.com/luci/luci-go@logdog-archive-v2
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: server/logdog/storage/storage.go
diff --git a/server/logdog/storage/storage.go b/server/logdog/storage/storage.go
index 3ef64078db637de73daf4780c07c6c7d28e2ff5f..57819b240e8b1a3690aee2ffa88aa950d89e5750 100644
--- a/server/logdog/storage/storage.go
+++ b/server/logdog/storage/storage.go
@@ -61,6 +61,10 @@ type GetRequest struct {
// The Storage instance may return fewer records than the supplied Limit as an
// implementation detail.
Limit int
+ // KeysOnly, if true, allows (but doesn't require) the Storage instance to
+ // omit entry data in its get callback. For scanning operations, this can be
+ // much cheaper/faster than full data queries.
+ KeysOnly bool
}
// GetCallback is invoked for each record in the Get request. If it returns
« server/logdog/storage/bigtable/rowKey.go ('K') | « server/logdog/storage/memory/memory.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698