Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: server/logdog/storage/memory/memory.go

Issue 1872903002: LogDog: Enable keys-only BigTable queries. (Closed) Base URL: https://github.com/luci/luci-go@logdog-archive-v2
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: server/logdog/storage/memory/memory.go
diff --git a/server/logdog/storage/memory/memory.go b/server/logdog/storage/memory/memory.go
index fdea97c96c38b0b291a7a5dcf70458e76fbc3f46..bc320d922f25657ee601772dc9d698e1204f7cf7 100644
--- a/server/logdog/storage/memory/memory.go
+++ b/server/logdog/storage/memory/memory.go
@@ -121,8 +121,11 @@ func (s *Storage) Get(req storage.GetRequest, cb storage.GetCallback) error {
// callback from accidentally mutating it. We reuse the data buffer to try
// and catch errors when the callback retains the data.
for _, r := range recs {
- dataCopy := make([]byte, len(r.data))
- copy(dataCopy, r.data)
+ var dataCopy []byte
+ if !req.KeysOnly {
+ dataCopy = make([]byte, len(r.data))
+ copy(dataCopy, r.data)
+ }
if !cb(r.index, dataCopy) {
break
}

Powered by Google App Engine
This is Rietveld 408576698