Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1356)

Issue 1872893002: Revert of AppListController refactoring part 2: Ash's AppListShowerDelegate imlementation. (Closed)

Created:
4 years, 8 months ago by beaudoin1
Modified:
4 years, 8 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@mus_chrome_delegates_app_list_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of AppListController refactoring part 2: Ash's AppListShowerDelegate imlementation. (patchset #8 id:160001 of https://codereview.chromium.org/1856943003/ ) Reason for revert: Suspected to be causing that Mac problem: https://build.chromium.org/p/chromium/builders/Mac/builds/14169 Original issue's description: > AppListController refactoring part 2: Ash's AppListShowerDelegate imlementation. > > Part 1 of the refactoring: https://crrev.com/1830293002 > Design doc: https://docs.google.com/document/d/1M9vqTTuprMssRXs8UIVaFjQUq3lUxSzwrWoPjPvca6Q/edit?ts=56d0e9f0#heading=h.b2znwtuxd2x2 > > This CL adds ash::AppListShowerDelegate, which is the Ash implementation of > app_list::AppListShowerDelegate. At this point it is unused - Ash is still using > the old ash::AppListController class to control the app list. > > BUG=557408 > > Committed: https://crrev.com/412803081c9d4f4321d267133512f45ce434fc10 > Cr-Commit-Position: refs/heads/master@{#386123} TBR=sky@chromium.org,mgiuca@chromium.org,xiyuan@chromium.org,mfomitchev@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -761 lines) Patch
M ash/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
D ash/app_list/app_list_shower_delegate.h View 1 chunk +0 lines, -102 lines 0 comments Download
D ash/app_list/app_list_shower_delegate.cc View 1 chunk +0 lines, -357 lines 0 comments Download
D ash/app_list/app_list_shower_delegate_factory.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ash/app_list/app_list_shower_delegate_factory.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D ash/app_list/app_list_shower_delegate_unittest.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D ash/app_list/app_list_view_delegate_factory.h View 1 chunk +0 lines, -25 lines 0 comments Download
M ash/ash.gyp View 6 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
beaudoin1
Created Revert of AppListController refactoring part 2: Ash's AppListShowerDelegate imlementation.
4 years, 8 months ago (2016-04-08 19:44:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872893002/1
4 years, 8 months ago (2016-04-08 19:44:29 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 19:44:31 UTC) #4
No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698