Issue 18728: Create a dialog box for the about:network view and kill the tab type....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18728: Create a dialog box for the about:network view and kill the tab type.... (Closed)

Created:
11 years, 11 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Create a dialog box for the about:network view and kill the tab type. This adds an AppendText method to the text field view. The job tracker stuff is just copied from the old network status file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8604

Patch Set 1 #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+481 lines, -454 lines)			Patch
M	chrome/browser/browser.vcproj	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View	2 chunks	+9 lines, -3 lines	0 comments	Download
D	chrome/browser/tab_contents/network_status_view.h	View	1 chunk	+0 lines, -117 lines	0 comments	Download
D	chrome/browser/tab_contents/network_status_view.cc	View	1 chunk	+0 lines, -320 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_factory.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_type.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
A	chrome/browser/views/about_network_dialog.h	View	1 chunk	+65 lines, -0 lines	0 comments	Download
A	chrome/browser/views/about_network_dialog.cc	View	1 chunk	+381 lines, -0 lines	1 comment	Download
M	chrome/browser/views/browser_views.vcproj	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/views/text_field.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/views/text_field.cc	View	3 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 11 months ago (2009-01-23 23:24:23 UTC) #2

LGTM

http://codereview.chromium.org/18728/diff/1/2
File chrome/browser/views/about_network_dialog.cc (right):

http://codereview.chromium.org/18728/diff/1/2#newcode24
Line 24: const wchar_t KShowCurrentLabel[] = L"Show Current";
K?

Expand Messages | Collapse Messages