Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(400)

Issue 18728: Create a dialog box for the about:network view and kill the tab type.... (Closed)

Created:
10 years, 6 months ago by brettw
Modified:
8 years, 3 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Create a dialog box for the about:network view and kill the tab type. This adds an AppendText method to the text field view. The job tracker stuff is just copied from the old network status file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8604

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+481 lines, -454 lines) Patch
M chrome/browser/browser.vcproj View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 2 chunks +9 lines, -3 lines 0 comments Download
D chrome/browser/tab_contents/network_status_view.h View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/tab_contents/network_status_view.cc View 1 chunk +0 lines, -320 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_factory.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_type.h View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/browser/views/about_network_dialog.h View 1 chunk +65 lines, -0 lines 0 comments Download
A chrome/browser/views/about_network_dialog.cc View 1 chunk +381 lines, -0 lines 1 comment Download
M chrome/browser/views/browser_views.vcproj View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/views/text_field.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/views/text_field.cc View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
10 years, 6 months ago (2009-01-23 22:11:04 UTC) #1
Ben Goodger (Google)
10 years, 6 months ago (2009-01-23 23:24:23 UTC) #2
LGTM

http://codereview.chromium.org/18728/diff/1/2
File chrome/browser/views/about_network_dialog.cc (right):

http://codereview.chromium.org/18728/diff/1/2#newcode24
Line 24: const wchar_t KShowCurrentLabel[] = L"Show Current";
K?

Powered by Google App Engine
This is Rietveld 408576698