Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: content/browser/service_worker/service_worker_context_core.h

Issue 1872673002: DevTools: introduce the bypass service worker checkbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_core.h
diff --git a/content/browser/service_worker/service_worker_context_core.h b/content/browser/service_worker/service_worker_context_core.h
index 2551336bd457db262d528ccb30a80175867b1567..5a3b879cd0a0804ea62329e0a399bad965e0ac9f 100644
--- a/content/browser/service_worker/service_worker_context_core.h
+++ b/content/browser/service_worker/service_worker_context_core.h
@@ -212,9 +212,20 @@ class CONTENT_EXPORT ServiceWorkerContextCore
// loading is delayed until the update completes and the new worker is
// activated. The new worker skips the waiting state and immediately
// becomes active after installed.
- bool force_update_on_page_load() { return force_update_on_page_load_; }
- void set_force_update_on_page_load(bool force_update_on_page_load) {
- force_update_on_page_load_ = force_update_on_page_load;
+ bool update_on_page_load_for_devtools() {
+ return update_on_page_load_for_devtools_;
+ }
+ void set_update_on_page_load_for_devtools(bool update_on_page_load) {
+ update_on_page_load_for_devtools_ = update_on_page_load;
+ }
+
+ // Used in DevTools to force load page from network, bypassing service
+ // worker.
+ bool fallback_to_network_for_devtools() {
+ return fallback_to_network_for_devtools_;
+ }
+ void set_fallback_to_network_for_devtools(bool fallback_to_network) {
+ fallback_to_network_for_devtools_ = fallback_to_network;
}
// This class maintains collections of live instances, this class
@@ -347,7 +358,8 @@ class CONTENT_EXPORT ServiceWorkerContextCore
std::map<int, ServiceWorkerNavigationHandleCore*>
navigation_handle_cores_map_;
- bool force_update_on_page_load_;
+ bool update_on_page_load_for_devtools_;
+ bool fallback_to_network_for_devtools_;
int next_handle_id_;
int next_registration_handle_id_;
// Set in RegisterServiceWorker(), cleared in ClearAllServiceWorkersForTest().

Powered by Google App Engine
This is Rietveld 408576698